You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since @alexeagle was concerned about editor support, I've manually tested this change within vscode - as expected, there are no changes required to vscode to make it work, you just drop in the new tsserver. 😉
Once this is merged and we do an LKG (so our lib folder has the feature), I'll update all of our own configs to make use of this feature - it'll seriously reduce the duplication in our options (and likely simplify our Gulpfile a lot!)
The reason will be displayed to describe this comment to others. Learn more.
jsdoc would be nice here, specifically calling out what happens when keys are mapped to the same key (looks like last one wins and earlier ones are discarded)
@mhegazy Is there a reason multiple inheritance was undesirable? IMO, It was useful for mixing in a standard set of debug options into another config hierarchy to avoid duplication.
sorry should have explained that before making the change. We have discussed it int he last design meeting. ppl felt that multiple inheritance complicates things and would not be super useful. if there are requests later on, we could add it back. Here are the notes: #10566
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
APIRelates to the public API for TypeScriptBreaking ChangeWould introduce errors in existing code
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9876
Implements with the semantics proposed in that issue.