| CARVIEW |
Select Language
HTTP/2 301
date: Thu, 24 Jul 2025 20:27:19 GMT
content-length: 0
location: https://github.com/chakra-core/ChakraCore/pull/926
server-timing: nginx;desc="NGINX";dur=1.449175,glb;desc="GLB";dur=102.296075
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=NMdNMrXTZWa2iplfH4e8PwuOUuSrqB31AS9GWMtYca0DgKj7giKljny4SX5oS2P0fb3AnqW2UKD9L2KMPj3HKYfhms6vjUPTFeynR0RNzvm7ObetwrEYV6KwuRhjlKu6rqnaBUPswEjFL9dFjr3yefk49AZQpJGAR94gJ2lPAlJfrgOCEV56Kxh9Z9yW6hQQk7Cw%2F2FAeSS6jZmZtes0DD2eA2XdUK7RSvOip7BMzWVnKHUgcOSdkT9nJOE4WONrrg6f5gl9wzKd2xMNHvaljw%3D%3D--%2Bty0zdayyQBK9bqc--DvV3OcBGkqlGpZmfnVjYOw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.360264385.1753388839; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 20:27:19 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 20:27:19 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C0F6:63E3F:4B20D:64FFC:68829727
HTTP/2 200
date: Thu, 24 Jul 2025 20:27:21 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=308.693311,conversation_content-fragment;desc="conversation_content fragment";dur=1112.675958,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=251.280706,nginx;desc="NGINX";dur=1.065987,glb;desc="GLB";dur=100.863908
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: C0F6:63E3F:4B221:65016:68829727
New debugging APIs by agarwal-sandeep · Pull Request #926 · chakra-core/ChakraCore · GitHub
agarwal-sandeep
force-pushed
the
JsRTDebugging
branch
from
May 10, 2016 01:38
agarwal-sandeep
force-pushed
the
JsRTDebugging
branch
from
May 11, 2016 16:32
agarwal-sandeep
force-pushed
the
JsRTDebugging
branch
from
May 11, 2016 16:45
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New debugging APIs #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
New debugging APIs #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akroshg @Yongqu @liminzhu @aruneshchandra please take a look |
agarwal-sandeep
force-pushed
the
JsRTDebugging
branch
from
c7ae96f to
190acfb
Compare
| { | ||
| "scriptId": 3, | ||
| "fileName": "dummyfilename.js", | ||
| "lineCount": 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no scripttype for .js file or we are not logging it? #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script type is only for dynamic script which doesn't have a filename. For such scripts filename is replaced with scriptType #Closed
| LPCUTF8 source = functionBody->GetStartOfDocument(_u("Source for debugging")); | ||
| size_t startByte = utf8::CharacterIndexToByteIndex(source, functionBody->GetUtf8SourceInfo()->GetCbLength(), (const charcount_t)statementMap->sourceSpan.begin); | ||
|
|
||
| int byteLength = statementMap->sourceSpan.end - statementMap->sourceSpan.begin; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by byteLength did you mean bytecodeLength, since it is little confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Looking good overall :). Left a few nitpicks here and there. |
agarwal-sandeep
force-pushed
the
JsRTDebugging
branch
from
190acfb to
2137d11
Compare
agarwal-sandeep
added a commit
that referenced
this pull request
May 11, 2016
agarwal-sandeep
force-pushed
the
JsRTDebugging
branch
from
2137d11 to
78c7913
Compare
chakrabot
pushed a commit
that referenced
this pull request
May 11, 2016
Merge pull request #926 from JsRTDebugging This PR adds debugging APIs to _ChakraCore_ and test debugger to ch. Sample tests are under [test\Debugger](https://github.com/Microsoft/ChakraCore/tree/JsRTDebugging/test/Debugger). Once this PR is merged next PR will port existing PDM based debugger tests to run with ch/ChakraCore. I have already run those tests and don’t see any issue. New APIs are prefixed with _JsDiag_ to group them under a pseudo namespace, in future if we plan to have other diagnostic APIs this will help. There are a total of 17 JsDiag* APIs. Currently the APIs on only exposed in ChakraCore once we have windows review this will be exposed in Chakra as well. With this change the binary size of ChakraCore/Chakra increase by about a max of 19KB across all architectures which is acceptable. To demonstrate the use, capabilities and completeness of these APIs [Node-ChakraCore](https://github.com/nodejs/node-chakracore) have been enhanced to provide debugging support with [VSCode](https://code.visualstudio.com/) (no change to VSCode required). ChakraCore code in Node-ChakraCore is synced with this PR commit. The code is available at https://github.com/agarwal-sandeep/node-chakracore/tree/debugging There is some more investigation required to make [Node-Inspector]( https://github.com/node-inspector/node-inspector) work with Node-ChakraCore. I am working on it.
|
Is this Visual Studio compatible? I can not try to step into Javascript code in Visual Studio with codes mix with C++ and Javascript |
|
@MidoriYakumo VisualStudio support debugging using Chakra and PDM and is currently not supported for ChakraCore. If your scenario runs using node the you can use Node-ChakraCore to debug using VSCode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR adds debugging APIs to ChakraCore and test debugger to ch.
Sample tests are under test\Debugger. Once this PR is merged next PR will port existing PDM based debugger tests to run with ch/ChakraCore. I have already run those tests and don’t see any issue.
New APIs are prefixed with JsDiag to group them under a pseudo namespace, in future if we plan to have other diagnostic APIs this will help.
There are a total of 17 JsDiag* APIs. Currently the APIs on only exposed in ChakraCore once we have windows review this will be exposed in Chakra as well.
With this change the binary size of ChakraCore/Chakra increase by about a max of 19KB across all architectures which is acceptable.
To demonstrate the use, capabilities and completeness of these APIs Node-ChakraCore have been enhanced to provide debugging support with VSCode (no change to VSCode required). ChakraCore code in Node-ChakraCore is synced with this PR commit. The code is available at https://github.com/agarwal-sandeep/node-chakracore/tree/debugging
There is some more investigation required to make Node-Inspector work with Node-ChakraCore. I am working on it.