CARVIEW |
Select Language
HTTP/2 200
date: Sun, 12 Oct 2025 12:28:47 GMT
content-type: text/html; charset=utf-8
cache-control: max-age=0, private, must-revalidate
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
link: ; rel=preload; as=fetch; crossorigin=use-credentials
referrer-policy: no-referrer-when-downgrade
server-timing: issue_layout-fragment;desc="issue_layout fragment";dur=169.731556,issue_conversation_content-fragment;desc="issue_conversation_content fragment";dur=675.807926,nginx;desc="NGINX";dur=1.235979,glb;desc="GLB";dur=143.654091
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With, Accept,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=9tMzYo5mICDT%2BdORmbB%2BSRgR5PufZeJ34cC6snTLBVy1i4za3r1adp6D%2BM0UzIum13jgrolVOzDHOeGA%2B1z9%2FdvoJeWY16daXd50F7XTQ9EndVRUGWQswtAQiCecnbIEG%2FgDx0txl8La2XIkO%2F7G99wyP7L%2F1RJCkdRLcmqWcB%2FxXFK95a4sf0rvF0Tqj2errVLupe7qD%2B2jKxKGRvah7YsGtbN1JvzVUlyh9Mk14XMSTq62s8sbVp9wjjYSzveSHBTbJukQukU1JpFxfrjjwQ%3D%3D--JfC1g6uDqHu%2BVHpu--s2deptIRIbqH%2BKAPoYlgVA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1586998987.1760272126; Path=/; Domain=github.com; Expires=Mon, 12 Oct 2026 12:28:46 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 12 Oct 2026 12:28:46 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CC38:136466:F456E8:1457C98:68EB9EFE
ConcurrentModificationException · Issue #839 · ESAPI/esapi-java-legacy · GitHub
No one assignedNo typeNo projectsNo milestoneNone yetNo branches or pull requests
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 370
Closed
Labels
Description
Describe the bug
JavaLogFactory.java's readLoggerConfiguration function throws ConcurrentModificationException at this line
if (System.getProperties().keySet().stream().anyMatch(propKey ->
"java.util.logging.config.class".equals(propKey) || "java.util.logging.config.file".equals(propKey)))
in a multi-threaded environment when another thread is concurrently setting system properties while ESAPI is iterating over system properties.
Specify what ESAPI version(s) you are experiencing this bug in
2.5.2.0
To Reproduce
public class Reproduce {
public static void main(String[] args) {
Thread t = new Thread(new Runnable() {
public void run() {
while (true) {
long time = System.currentTimeMillis();
// Emulate another thread modifying system properties
System.setProperty(time + "", time + "");
try {
Thread.sleep(500);
} catch (InterruptedException e) {
e.printStackTrace();
}
}
}
}); t.start();
EsapiThread esapiThread = new EsapiThread();
esapiThread.start();
}
private static class EsapiThread extends Thread {
public void run() {
// Emulate the code of JavaLogFactory in ESAPI
System.getProperties().keySet().stream().anyMatch(a -> {
try {
Thread.sleep(2000);
} catch (InterruptedException e) {
throw new RuntimeException(e);
}
return "dummy".equals(a);
});
}
}
}
Expected behavior
Proposed change: copy the System.getProperties().keySet()
to a new collection and iterating over the new collection instead of the original one to avoid thread safety problem.
Platform environment (please complete the following information)
- JDK version: JDK8
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
Issue actions
You can’t perform that action at this time.