You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
PRs will be reviewed from oldest to newest
If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.
Purpose
Upgrade Dynamo VS Studio solution to reference latest IronPython 2.7.9. As a result of this PR, Microsoft.VisualStudio.CodeCoverage.Shim.dll will no longer be part of DynamoCore delivery. I believe there was no real hard dependency on that dll and we included that dll for some unknown reason..
That dll is no longer delivered as part of DynamicRuntimeLanguage 1.2.2 which IronPython 2.7.9 is depending on, see below image
@QilongTang if you are worried that integrators need that other dll for patching - we can just supply it as a post build step with a TODO and task to remove it later? - also thanks for jumping on this.
@aparajit-pratap@mjkkirschner@reddyashish Since our binary comparison job can only compare nugets and testing on this upgrade did not give my anything obvious yet (Self CI passed as well). I am going to merge this and do a binary comparison so we are sure about what dlls are affected.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
Upgrade Dynamo VS Studio solution to reference latest IronPython 2.7.9. As a result of this PR,
Microsoft.VisualStudio.CodeCoverage.Shim.dll
will no longer be part of DynamoCore delivery. I believe there was no real hard dependency on that dll and we included that dll for some unknown reason..That dll is no longer delivered as part of DynamicRuntimeLanguage 1.2.2 which IronPython 2.7.9 is depending on, see below image

Declarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of