| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 28 Jul 2025 00:35:42 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=277.194093,conversation_content-fragment;desc="conversation_content fragment";dur=744.020953,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=1353.815499,nginx;desc="NGINX";dur=1.396002,glb;desc="GLB";dur=100.601064
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=5G7ePSEhwIeV6lroDvGSWsIDgKb%2Fd6b%2FO%2B3lq3%2FRFUqr3Bs%2FQFObvh0lDGRnbsOJLoVgGesV8F0Z3VEWGK%2FjJ0sD0A%2F5oPYjydu0Si6hsttB8sn%2FoOEnnuK3QO%2ByrGqI89nd22LO60PGcb2KGH5AtDQ8KV78ITnRHvAFPLy%2Bq%2B2FGZabTdiPrSvUOx3FK016n3nhj2P41Ysgq2FT2KQxqWye%2Fg8jpF9qLgClk8rhPUnzIIBpDJZxuvXLgHY4OveAn8UNMYiVcZ2%2FYf4xLwdOKA%3D%3D--i9vydEuweL%2Fo95Eb--88mrxWYLQxBfD2slUj0A2w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2140643213.1753662940; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 00:35:40 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 00:35:40 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C1E0:0A67:792E44:9EDA02:6886C5DC
continue custom node element binding issues pt1 by mjkkirschner · Pull Request #9609 · DynamoDS/Dynamo · GitHub
mjkkirschner
changed the title
[WIP] continue custom node element binding issues pt1
continue custom node element binding issues pt1
Apr 2, 2019
aparajit-pratap
added
LGTM
Looks good to me
and removed
PTAL
Please Take A Look 👀
labels
Apr 5, 2019
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
continue custom node element binding issues pt1 #9609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add test which fails before change
mjkkirschner
changed the title
|
test files are something like this: where the callsite data has been generated manually, encoded into base64 and added to the file - then the functionScope has been altered to something like |
|
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjkkirschner do any of the tests you added test the case where (1) there are more than one creation nodes inside the same custom node definition?
| CurrentDynamoModel.TraceReconciliationProcessor = new TestTraceReconciliationProcessor(0); | ||
| Assert.AreEqual(6, ws.Nodes.Count()); | ||
| var dummyNodes = ws.Nodes.OfType<DummyNode>(); | ||
| Assert.AreEqual(0, dummyNodes.Count()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we just use AssertNoDummyNodes function here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently I think that method is only implemented for system tests: this is a model test - do you want me to implement something like that in modelTestBase?
- we also still need to check if the custom node was loaded as when it fails it's not marked as a dummy node.
|
@aparajit-pratap - yes, the custom node definition here has two creation nodes with the same name / function signature inside it. |
|
LGTM! |
aparajit-pratap
added
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
continues this PR from @aparajit-pratap : #9527
please see his PR for a very good writeup of the issue and explanation of his fix.
I'm doing some testing and adding automated tests. Also considering edge cases that might arise.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@aparajit-pratap
@scottmitchell
FYIs
@smangarole
@ZiyunShang
@AndyDu1985