| CARVIEW |
Select Language
HTTP/2 200
date: Tue, 29 Jul 2025 16:58:19 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=354.703286,conversation_content-fragment;desc="conversation_content fragment";dur=744.709482,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=337.117996,nginx;desc="NGINX";dur=0.953658,glb;desc="GLB";dur=100.858738
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=cYIU1HXfERzsH3lfqETxsc6J90FyBzUDLiUY5MLvgfySqbGkufyW4Jtuiy4zDTZtHThTWmGIWr44kqB9eJBfY4%2B%2FcKW85OrXj%2F%2FXzsRpIWYnA9O90MFVghzoAXp%2BipuAADEOYoWXVcxavK%2B10bDb1Xb0Rkm63ehe2jejq883CKzddf36rlL5g2tRPBacSIbPIInPCG%2Bca7s4wgK6PLc4J2Otx7hqJGi8LI5Tu%2F5K8NMkRwHHSxtayTOHdqIl77mMS0J0IEdZSflBA1wgrvgOHw%3D%3D--Vr8HJ5i%2BTutmP3L%2B--X%2FCb8SWNZwwdBjCVbi96fg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.242345562.1753808299; Path=/; Domain=github.com; Expires=Wed, 29 Jul 2026 16:58:19 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 29 Jul 2026 16:58:19 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9BEA:3A6694:E2E95E:10C2AE2:6888FDAB
Rc2.0.3 lib crash by mjkkirschner · Pull Request #9568 · DynamoDS/Dynamo · GitHub
horatiubota
added
the
error/warning/crash
Issues mentioning a Dynamo error, warning or crash message
label
Nov 11, 2019
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Rc2.0.3 lib crash #9568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mjkkirschner
merged 2 commits into
DynamoDS:RC2.0.3_master
from
mjkkirschner:RC2.0.3_libCrash
Mar 14, 2019
Merged
Rc2.0.3 lib crash #9568
mjkkirschner
merged 2 commits into
DynamoDS:RC2.0.3_master
from
mjkkirschner:RC2.0.3_libCrash
Mar 14, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjkkirschner
commented
Mar 13, 2019
| @@ -74,9 +74,9 @@ protected Stream GetNodeItemDataStream(IEnumerable<NodeSearchElement> searchEntr | |||
| protected virtual object CreateObjectForSerialization(IEnumerable<NodeSearchElement> searchEntries) | |||
| { | |||
| var data = new LoadedTypeData<LoadedTypeItem>(); | |||
| data.loadedTypes = searchEntries | |||
| //.Where(e => !e.ElementType.HasFlag(ElementTypes.Packaged)) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aparajit-pratap @reddyashish @ColinDayOrg - it just occurs to me that this commented out code is kind of peculiar, does anyone know why this was left in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry was waiting for others to see if they knew about this. I am not sure why that line was commented in the first place. I assumed we are not using that attribute filter anymore.
The changes look good.
horatiubota
added
the
error/warning/crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
error/warning/crash
Issues mentioning a Dynamo error, warning or crash message
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
@reddyashish does this look correct?