You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following node preview for a Dictionary in a CBN containing multple output ports does not expand currently. This is the screenshot after the fix:
This is because preferredDictionaryOrdering was a list of empty strings (3 in this case, one for each output port) and even though it should have been ignored it passed the check in DefaultWatchHandler::ProcessThing. This fix it to prevent the list from containing empty strings. Note that preferredDictionaryOrdering must only be populated for multi output nodes that have a MultiReturnAttribute.
@aparajit-pratap misunderstood, so previously the dictionary was not displayed for multi return functions called in code blocks if one of the outputs was an empty string?
@mjkkirschner previously the dictionary could not be expanded in the preview if it was the output of a multi-output port code block node. Please don't confuse yourself with the contents of this Dictionary in the above example.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The following node preview for a Dictionary in a CBN containing multple output ports does not expand currently. This is the screenshot after the fix:

This is because
preferredDictionaryOrdering
was a list of empty strings (3 in this case, one for each output port) and even though it should have been ignored it passed the check inDefaultWatchHandler::ProcessThing
. This fix it to prevent the list from containing empty strings. Note thatpreferredDictionaryOrdering
must only be populated for multi output nodes that have aMultiReturnAttribute
.Declarations
Check these if you believe they are true
*.resx
filesReviewers
@mjkkirschner
FYIs
@jnealb