| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 28 Jul 2025 00:35:03 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=372.276926,conversation_content-fragment;desc="conversation_content fragment";dur=1014.157998,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=313.269233,nginx;desc="NGINX";dur=1.009024,glb;desc="GLB";dur=101.016972
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=%2F2cd7APvzHfg8VtUydH4Cb7lobVJgAKu9Cg178NslBZPBUcu%2BARnqQMU5IjetcVIcTDQ1gL70KMrHPuYNIj4C4fNCfm%2BSwqodbF0I3U%2BZS44AYaPP7ekVax4NrldwxV6q6m4RSn%2BQG0fGquBNKRhyGEa3KLpnNzwRkuylaNY7%2FVSqowlPBSQJRneNO1vSFErlwcgQKe77MECIB4TMmMi%2FAgPkl7XJEZnHvll4zehUOuWC4iG%2BEQF1eZDEIQkUgtZ0f7fBpmaM5ttwhshCmqAJQ%3D%3D--3rVwHFxcWhfAdpgH--2KXiUmkCboJbbChC91b1QA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.747157621.1753662902; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 00:35:02 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 00:35:02 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8A10:1A1F38:126AD09:1859A82:6886C5B6
DYN-8564: run autocomplete search in background thread by chubakueno · Pull Request #16265 · DynamoDS/Dynamo · GitHub
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-8564: run autocomplete search in background thread #16265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8564
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR moves the ML autocomplete call to a background thread and adds a loading state flag to toggle between a spinner stripe and the search results UI.
- Introduces a
ResultsLoadedproperty and wraps the ML request inTask.Run - Adds error handling and marshals UI updates via the dispatcher
- Updates the XAML to show a
LoadingAnimationStripeControlwhile results are loading
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs | Adds ResultsLoaded, moves ML call to a background thread, and dispatches UI updates |
| src/DynamoCoreWpf/Controls/NodeAutoCompleteSearchControl.xaml | Defines an inverse visibility converter and binds the spinner/control visibility to ResultsLoaded |
Comments suppressed due to low confidence (1)
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs:335
- [nitpick] The method name
UpdateUIWithRresultscontains a typo (Rresults). Consider renaming it toUpdateUIWithResultsfor clarity and consistency.
private void UpdateUIWithRresults(MLNodeAutoCompletionResponse MLresults)
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
BogdanZavu
reviewed
Jun 4, 2025
| @@ -47,6 +48,17 @@ public class NodeAutoCompleteSearchViewModel : SearchViewModel | |||
| private const string nodeClusterAutocompleteMLEndpoint = "MLNodeClusterAutocomplete"; | |||
| internal bool IsOpen { get; set; } | |||
|
|
|||
| private bool resultsLoaded; | |||
| public bool ResultsLoaded | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need this to be public due to the binding. Let's add a comment an d also make it obsolete.
BogdanZavu
reviewed
Jun 4, 2025
BogdanZavu
approved these changes
Jun 4, 2025
|
Made a few comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Run autocomplete search in background thread and hide search box with animation stripe.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Run autocomplete search in background thread and hide search box with animation stripe.
Reviewers
@BogdanZavu
@johnpierson
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of