| CARVIEW |
Select Language
HTTP/2 200
date: Tue, 29 Jul 2025 02:17:15 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=377.330924,conversation_content-fragment;desc="conversation_content fragment";dur=2692.130353,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=328.959349,nginx;desc="NGINX";dur=1.42162,glb;desc="GLB";dur=102.806515
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=DlWGSfm4AaNFW%2FvJeFOsejztxjeIQEGsMVoIxWxoeyh6KPPDstXgYJEYFIE236eq7GoSrICbA2Y4XQDwxGXcyDoQnnQICzegn6Y9dkgzHibtTUdVN2hcLv5JOBJfZl%2F8CcFXJ0rSpkT2BNXHPeOg46oaTGfGhUo3FgtCrVc9mZTZPJ7WEhNEdEvkspe8horxoqyjFUyA7Aekdw%2BkZ9WVh87VfVlU7htK0TRRLzAdEtT48SKxAgdiEvyfJV9C6v3dJKrOTgmcQqXUeK2NHcWdRA%3D%3D--Lpm4PCjPPfoVgkov--Qzn21rLGI8X0gZw1JJqbkQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.775875243.1753755432; Path=/; Domain=github.com; Expires=Wed, 29 Jul 2026 02:17:12 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 29 Jul 2026 02:17:12 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9402:812B8:1C662E:2A236E:68882F28
8150: DYN-8176: Fixes from PythonNet3 by twastvedt · Pull Request #15774 · DynamoDS/Dynamo · GitHub
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
twastvedt
changed the title
DYN-8150: Fixes from PythonNet3
DYN-8176: Fixes from PythonNet3
Jan 22, 2025
github-actions
bot
changed the title
DYN-8176: Fixes from PythonNet3
8150: DYN-8176: Fixes from PythonNet3
Jan 22, 2025
twastvedt
changed the title
8150: DYN-8176: Fixes from PythonNet3
DYN-8176: Fixes from PythonNet3
Jan 23, 2025
github-actions
bot
changed the title
DYN-8176: Fixes from PythonNet3
8150: DYN-8176: Fixes from PythonNet3
Jan 23, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
8150: DYN-8176: Fixes from PythonNet3 #15774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8150
twastvedt
changed the title
github-actions
bot
changed the title
twastvedt
commented
Jan 22, 2025
| @@ -642,7 +641,6 @@ public void VerifySysPathValueForCPythonEngine() | |||
| var pynode = nodeModel as PythonNode; | |||
| UpdatePythonEngineAndRun(pynode, PythonEngineManager.CPython3EngineName); | |||
| sysPathList = GetFlattenedPreviewValues(secondPythonNodeGUID); | |||
| Assert.AreEqual(sysPathList.Count(), 3); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now can't be certain of the exact number of paths. But it should be enough (as we are doing) to check that the custom path is visible in the first node and not in the second.
UI Smoke TestsTest: success. 11 passed, 0 failed. |
BogdanZavu
reviewed
Jan 22, 2025
BogdanZavu
approved these changes
Jan 22, 2025
twastvedt
changed the title
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Apply a few fixes from PythonNet3 work to CPython3:
pathhandling. Currently we just chop off all but the first three path entries. This PR caches the path before all Python nodes run and uses the cached path for each run. This will fix, for example, the issue wheresite-packagesisn't on the path (If site-packages folder is present the default Python path has 4 items).Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Preserve full original Python path on each Python node run.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of