You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting the __doc__ docstrings in the IronPython2 can be very slow (15-100ms) for each call. Every time you press . on a large namespace or type, Dynamo (and possibly its host) freezes. Whenever you use the Autodesk.Revit.DB. namespace for example, Revit freezes for multiple seconds, making editing iron python 2 scripts a horrible experience.
Luckily the experience is much better in IronPython3 and getting the docstrings is much faster.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB
Release Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
I'm interested to understand what is actually slow here - it's not clear to me what the difference would be between ironpython2 and 3 - it looks like both of them are actually using the DSCPythonCodeCompletionProviderCore?
but ironPython3 just falls back to the DSCPython based one... I have no idea if it actually works though, it's just a fallback - so comparing their performance is not really appropriate.
I think likely this PR avoids eagerly doing whatever super slow stuff we have in the legacy IronPythonCodeCompletionProvider though so it seems okay to me.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Getting the
__doc__
docstrings in the IronPython2 can be very slow (15-100ms) for each call. Every time you press.
on a large namespace or type, Dynamo (and possibly its host) freezes. Whenever you use theAutodesk.Revit.DB.
namespace for example, Revit freezes for multiple seconds, making editing iron python 2 scripts a horrible experience.Luckily the experience is much better in IronPython3 and getting the docstrings is much faster.
Unfortunately, it CPython getting the docstrings has not been implemented yet.
This PR also implements lazy loading of the in the overarching class and delays the execution until the description is actually displayed and needed.
User Experience
This is what a user experiences currently (felt like 10 seconds to me):

And here's the now instantaneous experience with the proposed changes:

Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
@bendikberg, @mjkkirschner