| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 28 Jul 2025 07:04:47 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=488.824851,conversation_content-fragment;desc="conversation_content fragment";dur=1223.247994,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=523.282963,nginx;desc="NGINX";dur=1.630324,glb;desc="GLB";dur=101.927299
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=e5P7uf1Ewpocl%2F8%2FAqnl5n87vHRHCRxfZGZWKrynmjGHPD8KaDMu5oTEsOT07BHhVyllJ4oOWFr2FQU11gt7k7xZOR2ORq89W4Z1%2BgrDGvWDCdQAxlDY2ILeOMNGhTKreMxz8NrcWNyEj4lDu4eESByZUB12Z5tFcEV6I3rN%2F5iGNtc0W1KfIlQ3IjGhpy3Bbcyj5MFVrBVzlayZc7cM0KhSfBiL3pXC7NqJB3%2F0o8clrdYvYD0hnvEEjm38MyFR24MH204L3DlRp9piQi%2FIKA%3D%3D--JS3sheW9GNzQXUcM--P%2BoaLZ9zpzIUoFQxkpr1SA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1151579528.1753686286; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 07:04:46 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 07:04:46 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 914A:3C6DB4:C963EC:1060473:6887210E
DYN-7343: Pm search compatibility filters update by dnenov · Pull Request #15603 · DynamoDS/Dynamo · GitHub
dnenov
changed the title
Pm search compfilters update
DYN-7343: Pm search compatibility filters update
Nov 5, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-7343: Pm search compatibility filters update #15603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zeusongit
merged 3 commits into
DynamoDS:master
from
dnenov:pm-search-compfilters-update
Nov 5, 2024
Merged
DYN-7343: Pm search compatibility filters update #15603
zeusongit
merged 3 commits into
DynamoDS:master
from
dnenov:pm-search-compfilters-update
Nov 5, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- compatible and incompatible filters should be mutually exclusive - small ui fix with alternating row background color for the compatibility matrix
- aligning to website design, we convert any wildcard symbol to lowercase 'x' - only do it on the UI, not touching the actual string value (using converter) - alternating rows background color fix
dnenov
changed the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7343
UI Smoke TestsTest: success. 11 passed, 0 failed. |
zeusongit
approved these changes
Nov 5, 2024
QilongTang
reviewed
Nov 5, 2024
| @@ -6480,7 +6480,7 @@ | |||
| <Setter Property="BorderBrush" Value="{StaticResource DarkMidGreyBrush}" /> | |||
| <Setter Property="ColumnWidth" Value="Auto" /> | |||
| <Setter Property="GridLinesVisibility" Value="Vertical" /> | |||
| <Setter Property="VerticalGridLinesBrush" Value="{StaticResource DarkMidGreyBrush}" /> | |||
| <Setter Property="VerticalGridLinesBrush" Value="#646464" /> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm this looks like backward to me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this to match the design we have on Figma. It meant that I needed to add a new color to the swatch of colors we used so far. https://www.figma.com/design/MJh76m7bbafE3sjwLUTZhZ/Dynamo-package-manager-update?node-id=2397-31482&node-type=canvas&t=OCvkjGxUxDFeO1qW-0
I pushed a new commit making it a resource, which I should have done to begin with, apologies @QilongTang .
QilongTang
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question
|
Jenkins reports 1 test timing out, the test passes locally .. I don't see how it is connected with any of these changes.
|
Merging since the test in unrelated. And yes, I have seen that fail for other PRs too, is this related to this PR #15583? fyi @reddyashish |
zeusongit
pushed a commit
to zeusongit/Dynamo
that referenced
this pull request
Nov 5, 2024
9 tasks
|
The tests passed on that PR though. I will check that test again with those changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
A few minor issues/alignments to push before 3.4.
UI Changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
CompatibleandIncompatiblefilters are now exclusive @QilongTang @hwahlstrom*toxconversion for the UIcompatibility matrixReviewers
@zeusongit
@QilongTang
FYIs
@reddyashish