| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 19:48:17 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=359.354686,conversation_content-fragment;desc="conversation_content fragment";dur=991.50216,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=308.611498,nginx;desc="NGINX";dur=0.734944,glb;desc="GLB";dur=101.402869
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ZuwOdEbJeeiZzIHIPr%2BxUKTVavjaPMvIE4JhsRU45R715zg7YGb%2BcaA3zKugnCyWFfAfc5vkkvCwNXCY66iMAmGP4ixksvqgw%2Brfpmjdy%2FNLX9142Jb46V2iD71ghV7zjuY70kzTGdPaascKr53XDx2kXW0lCpgkaL%2Bx%2B2938p5motAPoUFlylXwPuxH7txxw1W04reRJiZXBL3cMCo2vXQ%2FxSwTcsPuYBp%2BYLzc23oTTeaCgVH5VgonWrkmm%2FVub5eFqAFeVqsKelKq1e9MhQ%3D%3D--HUkbbVG93JmHaC4q--VGIvXhU3e6l001%2BXfE8FPw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.308254435.1753645696; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 19:48:16 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 19:48:16 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E576:2F5ED7:1130BD9:168D11C:6886827F
[DYN-6621] Save "Don't show again" setting on splash screen close by zeusongit · Pull Request #14866 · DynamoDS/Dynamo · GitHub
zeusongit
changed the title
Save "Don't show again" setting on splash screen close
[DYN-6621] Save "Don't show again" setting on splash screen close
Jan 18, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
[DYN-6621] Save "Don't show again" setting on splash screen close #14866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeusongit
changed the title
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
reviewed
Jan 19, 2024
| @@ -600,9 +605,9 @@ public bool SignOut() | |||
| { | |||
| return RequestSignOut(); | |||
| } | |||
| public void CloseWindow() | |||
| public void CloseWindow(bool isCheckboxChecked) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are any of these API used in Dynamo Revit repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also instead of passing param, any other way to do it, e.g. static boolean saved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are any of these API used in Dynamo Revit repo?
The APIs are not used in DynamoRevit
zeusongit
commented
Jan 19, 2024
| @@ -604,5 +628,9 @@ public void CloseWindow() | |||
| { | |||
| RequestCloseWindow(); | |||
| } | |||
| public void CloseWindowPreserve(bool isCheckboxChecked) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overload does not seem to work in Javascript context, I am getting this error: Invalid number of parameters in console. It is probably getting confused or maybe overloads don’t work in script object. The other solution is to use a new method. I have update the PR please take a look. @QilongTang
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
approved these changes
Jan 22, 2024
mjkkirschner
pushed a commit
to mjkkirschner/Dynamo
that referenced
this pull request
Mar 14, 2024
…namoDS#14866) * Update SplashScreen.xaml.cs * Update SplashScreen.xaml.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
https://jira.autodesk.com/browse/DYN-6621
If the "Don't show again" option on the splash screen is checked while closing it from the splash screen close button, the setting will be saved and the splash screen will not pause on the next run.
SplashScreen PR: DynamoDS/SplashScreen#49
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@DynamoDS/dynamo