| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 28 Jul 2025 08:05:19 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=2281.527199,conversation_content-fragment;desc="conversation_content fragment";dur=2389.776085,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=2064.194042,nginx;desc="NGINX";dur=1.021971,glb;desc="GLB";dur=104.610951
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=s9ttnfpb5LeZFu7ufqv0D3YMcHdZlGLWYekqR43m4YSGay%2FOVpTqH03nSepvhrQWfdNaODmi3kbIB8Fj02ewIdpRFZD8gBVL9SASNrHs4%2FXmb45RtyJrOlcG2WRsO0ax78M08nWiYxIX0%2FvTwxlD0VuONfMmDkoyQoBLESpGMUK8UmJ0%2FbNvVXmvp9iavONj%2B54ISFMQUMFPBvIbEK7lfoHQ8lvgiwGcyGMX2V1E%2FWScTLIo1zBH8SbFJsyOgdy3L0wgkGeMk6ht5GpUoyL0LQ%3D%3D--cqPfqPP1jQuJ6Xi9--moFELmmgy9S0oLOQjddk%2Fg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.154803273.1753689917; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 08:05:17 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 08:05:17 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DD80:15E61D:162FB8E:1C98F35:68872F3D
AGD-3133: Add Dynamo Preference Non-UI Flag for legacy behavior by saintentropy · Pull Request #14575 · DynamoDS/Dynamo · GitHub
saintentropy
changed the title
Add flag
Add Dynamo Preference Non-UI Flag for legacy behavior
Nov 6, 2023
twastvedt
changed the title
Add Dynamo Preference Non-UI Flag for legacy behavior
AGD-3131: Add Dynamo Preference Non-UI Flag for legacy behavior
Jan 30, 2024
twastvedt
changed the title
AGD-3131: Add Dynamo Preference Non-UI Flag for legacy behavior
AGD-3133: Add Dynamo Preference Non-UI Flag for legacy behavior
Jan 30, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
AGD-3133: Add Dynamo Preference Non-UI Flag for legacy behavior #14575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saintentropy
changed the title
|
Whats the use case here? Concern is that it will be very easy for a dev to remove this thinking it's not used etc. |
|
Should we use inheritance so DynamoRevit actually has a settings object slightly different from sandbox? Does this apply to C3D? My concern is that this setting seems to only surface in Player and is not settable in Dynamo. |
|
I will update the comments on this implementation but @mjkkirschner and @QilongTang the goal here is to fix bugs that are being reported due to a legacy issue with the Dynamo Player server. (I added more detail to the description) We have planned to depreciate this behavior but follow the Revit model of providing an options to customers that really need the old way for one release year but require them to make a change in a config file. |
|
Not sure if that answers you question @QilongTang. The goal is to give each host the option to set this config for the application |
|
@saintentropy can you add a test? |
|
hey @saintentropy theres also a failure in here from some other preferences tests |
|
@mjkkirschner Good to go? |
twastvedt
changed the title
twastvedt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Add Non preference UI flag to Dynamo to allow users to enable legacy behavior of Dynamo Player graph parsing related to Outputs. When the player was first introduced there were no
isOutputproperty on the nodes. The various players used the renamed watch as a single to the Player to use them as outputs. Now that Dynamo has the output property the old behavior is causing bug reports. This change will allow the player to remove the old option but support it for a period of time. This flag and support will be removed in Dynamo 4.0.https://jira.autodesk.com/browse/AGD-3133
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
For Dynamo Player, the legacy behavior for setting an output was a renamed Watch node. This method was still supported when the IsOutput property was introduced. Dynamo Player is now deprecating the renamed Watch node method and adding support via Dynamo config file. This config option will be removed in a future release.
Reviewers
@mjkkirschner @twastvedt
FYIs
@QilongTang