You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing crash after opening and closing the PackageManager
After opening the Package Manager and closing it was crashing due that the LuceneSearchUtility.Writer was null (the second time we don't reach the PackageManagerSearchViewModel constructor so the InitializeLuceneConfig() was not called). Then for this fix if the PackageManagerSearchViewModel was already created then we have to call again the InitializeLuceneConfig().
After opening the Package Manager and closing it was crashing due that the LuceneSearchUtility.Writer was null (the second time we don't reach the PackageManagerSearchViewModel constructor so the InitializeLuceneConfig() was not called).
Then for this fix if the PackageManagerSearchViewModel was already created then we have to call again the InitializeLuceneConfig().
@QilongTang@reddyashish most of the checks passed, the only one Pending is SonarQube Scan, not sure why is Pending if I cannot see any task runing for DynamoCACoverage job
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing crash after opening and closing the PackageManager
After opening the Package Manager and closing it was crashing due that the LuceneSearchUtility.Writer was null (the second time we don't reach the PackageManagerSearchViewModel constructor so the InitializeLuceneConfig() was not called). Then for this fix if the PackageManagerSearchViewModel was already created then we have to call again the InitializeLuceneConfig().
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Fixing crash after opening and closing the PackageManager
Reviewers
@QilongTang @reddyashish
FYIs