CARVIEW |
Select Language
HTTP/2 200
date: Mon, 28 Jul 2025 06:58:21 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=263.71848,conversation_content-fragment;desc="conversation_content fragment";dur=484.051234,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=223.688943,nginx;desc="NGINX";dur=1.011042,glb;desc="GLB";dur=100.511114
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=O0ielr5zZtXP%2BAChvvvxKbGfuhkz6z45p4uQwgmViPEUDNI5nZro8SsiguooQjLbfjG5WaWdDaOd63pO2IoU6sBxdEWO9tRA1zDvcELjfHU6bOtz%2FLire2w3LnD9XChfOBE%2FPnuBVLTzvWxEXKDilpPwbJmbH9Qhz3Lw0ZPSw6M50n1VWH14Tjpd020L%2BR%2Fnr59BbROTJrcWZAk2pKuNmmzwWiSuZyMICf0evfb3z2XBf2qKqDpVriraYd0TJKvkfGA9idaaIDGWquXqMZCtgA%3D%3D--XfgQPatZBRhN%2Fqlv--mXnIdE9R%2F9k6149V48Hqow%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1047260888.1753685901; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 06:58:21 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 06:58:21 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B9A2:29FD1F:15BE7D2:1C6ECD9:68871F8D
DYN-4513 Improvement: Allow pin note to node via drag, hover and release by dnenov · Pull Request #13966 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-4513 Improvement: Allow pin note to node via drag, hover and release #13966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
reddyashish
merged 3 commits into
DynamoDS:master
from
dnenov:dnenov-drag&droppinnote-improvement
May 9, 2023
Merged
DYN-4513 Improvement: Allow pin note to node via drag, hover and release #13966
reddyashish
merged 3 commits into
DynamoDS:master
from
dnenov:dnenov-drag&droppinnote-improvement
May 9, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- will highlight Node when a Note is being hovered over it
- moved the new functionality into a separate method, as it was getting a bit too long - now only handles the case of a note being dragged over a node
- now successfully pins the note when the mouse is released and the note is over the node - will skip highlighting Nodes that already have a Note pinned (consistent with current behavior to not allow more than 1 pinned Note)
reddyashish
approved these changes
May 9, 2023
The failing test is a flaky one. We will need a UI automation test for this feature. Will add a task for that and merging this. |
@reddyashish did this make it into 2.18, or is it targeted for 2.19? |
This is in 2.19 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
An improvement allowing the user to drag-&-drop a Note over a Node, pinning it down. Below is the description of the task as set in the brief:
pin note to node
border update on hover state
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
The steps taken to create the new functionality are as follows:
Reviewers
@reddyashish
@Amoursol
FYIs