You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
PRs will be reviewed from oldest to newest
If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.
Purpose
per https://jira.autodesk.com/browse/DYN-4891, remove Node Font Size setting from Preferences Panel per customers' request. Customers intend to rely on graph zoom level instead.
Notice there is no effect on serialization because Dynamo does not serialize such a setting currently.
Before:
I did think about that. From the visual design perspective though - the toggle is only taking one line whereas the radio button for run mode takes 2 lines, so they don't really line up.
Maybe we can switch the position of the Pause splash screen and Run preview so those two are closer
I did think about that. From the visual design perspective though - the toggle is only taking one line whereas the radio button for run mode takes 2 lines, so they don't really line up. Maybe we can switch the position of the Pause splash screen and Run preview so those two are closer
Can we put the toggles on the same line? See below:
I did think about that. From the visual design perspective though - the toggle is only taking one line whereas the radio button for run mode takes 2 lines, so they don't really line up. Maybe we can switch the position of the Pause splash screen and Run preview so those two are closer
Can we put the toggles on the same line?
I wouldn't recommend that. I think putting two unrelated items in the same line could be confusing. In a perfect world, it's better for both the number format and number of recent files should be in their own line too. (I do understand we are trying to save space and avoiding having to scroll to much)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
per https://jira.autodesk.com/browse/DYN-4891, remove Node Font Size setting from Preferences Panel per customers' request. Customers intend to rely on graph zoom level instead.
Notice there is no effect on serialization because Dynamo does not serialize such a setting currently.
Before:
After:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
remove Node Font Size setting from Preferences Panel per customers' request
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of