CARVIEW |
Select Language
HTTP/2 200
date: Mon, 28 Jul 2025 20:17:16 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=304.239475,conversation_content-fragment;desc="conversation_content fragment";dur=432.119746,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=249.871875,nginx;desc="NGINX";dur=0.625062,glb;desc="GLB";dur=100.578018
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=nXVIDSBwhtpHsBb13ZG78%2FeFZhcBSrfuRmUYj6BN4qH7%2BTRJ7%2Fjl2Iqzbt3DxN%2B0r8tCV2%2BiVbmyXqB6R9GVdLvpul0vOinPZ4SWxoQMrgt7GQln6pGFbfrpYD6mzMaZsqkG%2BIbVxZS7hLAk4NPqpW%2BTi%2FI38W9NROcq8da6vIr8tgCEf0SkRTxmHAN9roJw0fRG5U93wd5gSFWlnZM7ejmJckmZh9fjAaTu4YPvMuMFjB0Q7RUsBJMkQCtU3UqYqKbjo6APmfx1QDMl9i9Y6w%3D%3D--CPaV%2FnsEKZUXiU3S--HBm8eAHyAeWu0j8z7QsM4A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1889732367.1753733835; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 20:17:15 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 20:17:15 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CBAA:E69F3:6CF2F:90F32:6887DACB
Pinned Note on Dismissed Warnings by dnenov · Pull Request #13128 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Pinned Note on Dismissed Warnings #13128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
reddyashish
merged 3 commits into
DynamoDS:master
from
dnenov:dnenov-bugfix-notedismisswarnings
Jul 22, 2022
Merged
Pinned Note on Dismissed Warnings #13128
reddyashish
merged 3 commits into
DynamoDS:master
from
dnenov:dnenov-bugfix-notedismisswarnings
Jul 22, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pinned Note correctly aligns to the Node once a Warning is dismissed
- for internal review, Commit may be reverted later - attempts to allow Copy/Paste for Pins (ConnectorPinModel) - working directly inside the Copy() and Paste() methods of DynamoModel
This reverts commit 056a7c1.
reddyashish
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some discussion, we will be addressing the ability to "copy Connector Pins when copying/pasting Nodes with Pinned Connectors" in a different task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
The purpose of this PR is to rectify an issue where a pinned Note would remain in the same offset location after a Warning (dialog) has been dismissed. Normally, a Note would correctly get pushed up to provide space for the Warning tooltip dialog. However, when a Warning is dismissed, the space provided is no longer needed. This PR fixes this issue.
A secondary purpose of this PR is to make sure a Warning Dialog is always displayed on top, even in case of a more recent UI element (note). Currently, a note added after a Warning has been registered will appear on top of the Warning, which should not be the case. (Postponed)
A third potential goal is to allow to copy Connector Pins when copying/pasting Nodes with Pinned Connectors. (WIP)
Pin Dismissed Warnings

Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Reviewers
@reddyashish
@mjkkirschner
FYIs
@Amoursol