You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@QilongTang@Jingyi-Wen
I displayed the whole link, it was unclear from the mockup, if we want the actual link or some clickable hyperlink like Site URL that opens the URL. Let me know if that is what was required, I will update the PR. Thanks.
@QilongTang@Jingyi-Wen I displayed the whole link, it was unclear from the mockup, if we want the actual link or some clickable hyperlink like Site URL that opens the URL. Let me know if that is what was required, I will update the PR. Thanks.
@QilongTang@Jingyi-Wen I displayed the whole link, it was unclear from the mockup, if we want the actual link or some clickable hyperlink like Site URL that opens the URL. Let me know if that is what was required, I will update the PR. Thanks.
Yeah this is intended. LGTM!
@Jingyi-Wen I believe we intend to have hyper links? No?
@QilongTang@Jingyi-Wen I displayed the whole link, it was unclear from the mockup, if we want the actual link or some clickable hyperlink like Site URL that opens the URL. Let me know if that is what was required, I will update the PR. Thanks.
Yeah this is intended. LGTM!
@Jingyi-Wen I believe we intend to have hyper links? No?
Oh my apologies I missed it, yes they should be hyper links
LGTM, can you also record a gif for demo purposes and maybe look for unit test possibilities for the two new properties you add? If we dont unit test them right now, I am fine skipping
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-4893
Display site URL and repository URL on package details view if available.
GIF:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/dynamo