Update WPFCLI to add keep alive startup param handling #12156

saintentropy · 2021-10-18T13:02:55Z

Purpose

The purpose of this pull request is to add the keep alive option to the WPFCLI. Originally this PR added the option to WPFCLI with an identical implementation to the CLI. That PR failed to work as the Thread.Sleep calls on the main thread interfered with the Dispatcher pattern utilized in the WPF Dynamo components. This implementation differs in that it starts the Dynamo Model and ViewModel on their own thread and the Main thread of the Console handles blocking with a more standard Console.ReadLine().

This PR also adds the ability for the WPFCLI running in keep alive mode to load view extensions as well as utilizing the Helix Watch3D implementation vs Default.

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated

Reviewers

TBD

FYIs

@BogdanZavu

# Conflicts: # src/DynamoWPFCLI/Program.cs

BogdanZavu · 2022-04-04T14:34:39Z

src/DynamoWPFCLI/Program.cs

                {
-                    model = Dynamo.Applications.StartupUtils.MakeModel(true, cmdLineArgs.ASMPath);
+                    var thread = new Thread(() => RunKeepAlive(cmdLineArgs));


Can we have a name for this thread so that is easily visible when debugging like the Scheduler thread?

BogdanZavu · 2022-04-04T14:36:46Z

src/DynamoWPFCLI/Program.cs

+            {
+                StartupDaynamo(cmdLineArgs);
+
+                Console.WriteLine("-----------------------------------------");


Now I realize that we probably want to show the console only in debug mode ? But we can deal with this later in other PR.

…behavior

saintentropy · 2022-04-04T14:56:38Z

src/DynamoCLI/Program.cs

                }
                else
                {
-                    model = Dynamo.Applications.StartupUtils.MakeModel(true);
+                    model = Dynamo.Applications.StartupUtils.MakeModel(true, string.Empty, cmdLineArgs.AnalyticsInfo);


@QilongTang Hi Aaron. Is this the correct way to update the MakeModel usage from the obsoleted methods

QilongTang · 2022-04-04T16:02:13Z

src/DynamoWPFCLI/DynamoWPFCLI.csproj

@@ -13,6 +13,7 @@
    <Reference Include="Microsoft.Practices.Prism">
      <HintPath>..\..\extern\prism\Microsoft.Practices.Prism.dll</HintPath>
    </Reference>
+    <Reference Include="WindowsBase" />


Any reason why we need to add this? Would this prevent running WPF CLI on linux based system?

It was necessary with the threading model required to load the ViewModel which makes sence since that also will not load on linux

saintentropy added 7 commits October 8, 2021 12:13

Update WPFCLI to add keep alive start up param

5186144

Load View extensions in WPF CLI

670ff0d

Move keepalvie to new thread

315868d

Additional changes

7892054

Changes for thumbnail generation

d97b7dc

Refactor keep alive function

d43d4b6

Remove Helix and startup of Dynamo View extensions

ec3237e

BogdanZavu approved these changes Nov 11, 2021

View reviewed changes

saintentropy added 3 commits March 24, 2022 15:32

Merge branch 'master' into LoadViewExtensions

d9543da

# Conflicts: # src/DynamoWPFCLI/Program.cs

Fix csproj

8dfc68d

Stop using obsolete MakeModel methods

252a06f

BogdanZavu reviewed Apr 4, 2022

View reviewed changes

Move ImportedPaths handling to Dynamo startup to match CLI keepalive …

ec2d1a3

…behavior

saintentropy changed the title ~~WIP Update WPFCLI to add keep alive start up param (version 2)~~ Update WPFCLI to add keep alive startup param handling Apr 4, 2022

saintentropy commented Apr 4, 2022

View reviewed changes

Add thread name for keepAlive

edad905

QilongTang reviewed Apr 4, 2022

View reviewed changes

saintentropy added 2 commits April 7, 2022 19:42

Merge branch 'master' into LoadViewExtensions

2e8fb20

Fix test

9f6e059

saintentropy merged commit ced6306 into DynamoDS:master Apr 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update WPFCLI to add keep alive startup param handling #12156

Update WPFCLI to add keep alive startup param handling #12156

Uh oh!

saintentropy commented Oct 18, 2021 •

edited

Loading

Uh oh!

BogdanZavu Apr 4, 2022

Uh oh!

saintentropy Apr 4, 2022

Uh oh!

BogdanZavu Apr 4, 2022

Uh oh!

saintentropy Apr 4, 2022

Uh oh!

QilongTang Apr 4, 2022

Uh oh!

QilongTang Apr 4, 2022 •

edited

Loading

Uh oh!

saintentropy Apr 4, 2022

Uh oh!

Uh oh!

Update WPFCLI to add keep alive startup param handling #12156

Update WPFCLI to add keep alive startup param handling #12156

Uh oh!

Conversation

saintentropy commented Oct 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Declarations

Reviewers

FYIs

Uh oh!

BogdanZavu Apr 4, 2022

Choose a reason for hiding this comment

Uh oh!

saintentropy Apr 4, 2022

Choose a reason for hiding this comment

Uh oh!

BogdanZavu Apr 4, 2022

Choose a reason for hiding this comment

Uh oh!

saintentropy Apr 4, 2022

Choose a reason for hiding this comment

Uh oh!

QilongTang Apr 4, 2022

Choose a reason for hiding this comment

Uh oh!

QilongTang Apr 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saintentropy Apr 4, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

saintentropy commented Oct 18, 2021 •

edited

Loading

QilongTang Apr 4, 2022 •

edited

Loading