You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is follow up to some previous optimizations within the Callsite class, specifically to the ExecWithZeroRI method related to Cross Product replication. A majority of these changes reduce temporary object allocations and associated GC time. The larger the data set the larger the impact of the optimization. This task covers:
Removing the AreParametersHomogeneousTypes method check as we can more efficiently depend on the FunctionEndPoint count. If the count is equal to 1 then we can directly resolve the finalFunctionEndPoint and cache it. The optimization was already in place but based on the AreParametersHomogeneousTypes which appears to be extraneous.
Rename FunctionEndPoint list variable name to plural for clarity
Adjust allocation of temporary parameter arrays outside of replication loop to save allocation and GC time.
Use DSArray directly to access parameters vs copying items to temporary arrays.
Set list capacity directly vs resizing dynamically after initialization.
saintentropy
changed the title
Callsite ExecWithZeroRI optimizations to improve Cross Product replication performance
Callsite ExecWithRISlowPath optimizations to improve Cross Product replication performance
Aug 23, 2021
@saintentropy Looks good. I have not seen any regressions. I have seen execution times drop up to 50% but I have not seen huge drops in use of temporary memory. But the heap is in much better shape after this changes.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-4230
This PR is follow up to some previous optimizations within the Callsite class, specifically to the ExecWithZeroRI method related to Cross Product replication. A majority of these changes reduce temporary object allocations and associated GC time. The larger the data set the larger the impact of the optimization. This task covers:
AreParametersHomogeneousTypes
method check as we can more efficiently depend on the FunctionEndPoint count. If the count is equal to 1 then we can directly resolve thefinalFunctionEndPoint
and cache it. The optimization was already in place but based on theAreParametersHomogeneousTypes
which appears to be extraneous.FunctionEndPoint
list variable name to plural for clarityDSArray
directly to access parameters vs copying items to temporary arrays.todo => validate test
Â
Declarations
Check these if you believe they are true
*.resx
filesReviewers
FYIs
@jasonstratton @QilongTang