| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 28 Jul 2025 20:16:44 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=306.83044,conversation_content-fragment;desc="conversation_content fragment";dur=914.548772,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=260.085224,nginx;desc="NGINX";dur=0.620934,glb;desc="GLB";dur=100.242831
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=modaKmmXEoDLuDyegZe%2FUodBTfaeoqO4Ex3qCjfkseG3aBB1PzsXppQmEF5Jl8ljI%2BI8OqO9u4UzrhWOA8SmJ471X8sm1WdMrVOpOSwDrKndYXNbHvjDw2Ervoy2NWjtrmujHBEN0lQOcrw%2FcOvtoVoCcjprb87kEE30QGbJ%2BpSkcShREErG0L2qX8R39LA0vTqzB7XAG8NsRohYHCjXfKs8buxFHjJ1Ayehj6X8r1h%2BfG2YR2zgkr%2BPFtpQddYaMAIaPcGsdOdvNeKyGA5A%2FA%3D%3D--kOO1wFdjJDwTTDuX--yg8XeRAvXCHBITuON0Yflg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1637200834.1753733803; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 20:16:43 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 20:16:43 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D5CA:3CFA5:6B1F7:8EB9B:6887DAAB
DYN-4229 GraphicDataProvider optimization for repeated calls to get similar object types for tessellation by saintentropy · Pull Request #11920 · DynamoDS/Dynamo · GitHub
saintentropy
changed the title
GraphicData provider ot
GraphicDataProvider optimization for repeated calls to get similar object types for tessellation
Aug 7, 2021
saintentropy
changed the title
GraphicDataProvider optimization for repeated calls to get similar object types for tessellation
DYN-4229 GraphicDataProvider optimization for repeated calls to get similar object types for tessellation
Oct 18, 2021
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-4229 GraphicDataProvider optimization for repeated calls to get similar object types for tessellation #11920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
saintentropy
merged 10 commits into
DynamoDS:master
from
saintentropy:GraphicDataProviderOtimization
May 23, 2022
Merged
DYN-4229 GraphicDataProvider optimization for repeated calls to get similar object types for tessellation #11920
saintentropy
merged 10 commits into
DynamoDS:master
from
saintentropy:GraphicDataProviderOtimization
May 23, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saintentropy
changed the title
|
In a test graph with a lot of repeated calls to Circle.ByPointRadius this call reduced the time spent in this method from .5s to .07s and also reduced temporary memory allocation by 90%. |
saintentropy
changed the title
sm6srw
approved these changes
May 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This looks solid to me. I did spend some time making sure Clear gets called when it should be called and it looks good.
Comment on lines
+145
to
+146
| private static Interpreter interpreter; | ||
| private static ProtoFFI.FFIObjectMarshaler marshaler; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do these need to be static?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are static because you only need one Interpreter and FFIObjectMarshaller for the GraphicDataProvider class until the runtime is reset. If you made the instances you would allocate permanently an interpreter and marshaller for every mirror data object and that would be worse than temporary allocation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the graphicdataprovider member for mirrordata is static too so it looks like there will only be one instance of graphicdataprovider ever but I guess it doesn't hurt to make these static here as well.
aparajit-pratap
approved these changes
May 20, 2022
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
https://jira.autodesk.com/browse/DYN-4229
This optimization is to short-circuit the repeated search for and allocation of numerous
CLRObjectMarshallerobjects duringUpdateRenderPackageAsyncTaskexecution. Right now, withinUpdateRenderPackageAsyncTask, we callmirrorData.GetData()for every object we are attempting to tessellate. Within that call, a new instance of an ObjectMarshaller allocated based on the objects type information. This optimization caches the ObjectMarshaller and reuses it if the object type is the same for repeated calls.Declarations
Check these if you believe they are true
*.resxfilesReviewers
TBD
FYIs
@jasonstratton @QilongTang