You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When markdown docs for nodes were added to the docs browser - the old NodeHelpPrompt control was no longer displayed. It's not used anywhere in Dynamo today and likely will not be.
This PR just obsoletes it, so we get rid of it later at a major release.
This PR removes the control, but leaves the test as it doesn't really have anything to do with the control - it tests a function on NodeModel and still passes.
@Astul-Betizagasti noted that currently they are obsoleting the old controls, so I think it's fine to do the same here for now until we discuss API surface rules.
@mjkkirschner, related about what you were saying about WPF Controls (not sure if you are just talking about Properties in the ViewModel or controls in the XAML file), some days ago I created a new pull request for enabling the Geometry Scaling and Render Precision features in the Preferences panel, so I deleted the old code related to the Geometry Scaling functionality (xaml, code behind, events, commands, methods .....), is that ok? or should I marked as Obsolete?
This is the pull request: #11657
@RobertGlobant20 - I'm not sure - I think the safest thing to do for now is to obsolete anything public, add a TODO and we should discuss with @QilongTang how to approach it.
If we are going to start treating public methods and classes in DynamoCoreWPF as excluded from our API we should message this out, and at the minimum it must be documented it in the github readme or dev docs.
AFAIK we do treat some extensions like this already - but it's not consistent or documented well.
for this PR - that was what I was going to do -
obsolete the unused controls for now.
file a task to remove them at 3.x time in any case.
discuss with teams if we want to create a new policy and how we should message it.
Currently, we are treating DynamoView out of API scope, which means we can move/delete XML wpf controls as we want. For any public properties exposed under DynamoViewModel, we were only obsoleting them.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When markdown docs for nodes were added to the docs browser - the old
NodeHelpPrompt
control was no longer displayed. It's not used anywhere in Dynamo today and likely will not be.This PR just obsoletes it, so we get rid of it later at a major release.This PR removes the control, but leaves the test as it doesn't really have anything to do with the control - it tests a function on NodeModel and still passes.
Declarations
Check these if you believe they are true
*.resx
files