You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR will enable the node autocompletion functionality on the output ports of the nodes. The node autocompletion model will find all the matching nodes which has atleast one input parameter matching the output port type of the selected node. When any of the search elements are clicked, it will create the node and connect the output port of the original node to the first available matching input port of the new node.
Things to discuss
When no matching search elements are found, do we want to return an empty list? Because the default nodes shown for the input nodes do not have any InPorts so we cannot show them for the output port.
reddyashish
changed the title
Node autocompletion for output ports of the Dynamo nodes.
Node autocompletion for output ports of Dynamo nodes.
Apr 22, 2021
reddyashish
changed the title
Node autocompletion for output ports of Dynamo nodes.
Enable Node Autocompletion for output ports of Dynamo nodes.
Apr 22, 2021
@mjkkirschner@QilongTang Addressed the comments.
For the output ports, I am modified it to only show the watch, watch 3D and Python nodes as the CBN node does not have any input parameters.
To store the data for Auto-completion node elements, I created a new class where we can add more attributes in the future. The NodeSearchElement is extending this class as the auto-completion API returns a list of NodeSearchElement and we would need this information in the NodeSearchElementViewModel to connect the port. What do you think about it?
The reason will be displayed to describe this comment to others. Learn more.
Can you re-iterate the purpose of this class by comments here? We cant inherit the NodeSearchElement class because auto-completion API returns a list of NodeSearchElement and we would need this information in the NodeSearchElementViewModel to connect the port? I am fine with this, @mjkkirschner@aparajit-pratap what do you think? I think we plan to keep expanding here because we will have more properties coming in specific to AutoComplete function, e.g. user's rank, whether favored, ML rank
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reddyashish
changed the title
Purpose
This PR is to address the task: https://jira.autodesk.com/browse/DYN-3344
This PR will enable the node autocompletion functionality on the output ports of the nodes. The node autocompletion model will find all the matching nodes which has atleast one input parameter matching the output port type of the selected node. When any of the search elements are clicked, it will create the node and connect the output port of the original node to the first available matching input port of the new node.
Things to discuss
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @zeusongit @mjkkirschner @aparajit-pratap