| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 19:55:34 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=402.087758,conversation_content-fragment;desc="conversation_content fragment";dur=809.824544,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=278.275884,nginx;desc="NGINX";dur=1.162528,glb;desc="GLB";dur=101.325474
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=8V%2BJUnGgBSMjF0IYd3oVTJc19nh50Oi3JobJJo9bjomvJg5pIczOfceRMELvKyqxRf%2BlbpEga%2BvbKEFdTJlpecIQw%2BiXC%2Bc4J7CQib4KnuIyaYSVFUQAupd6IMJ2B682XdPDCjLFSLrf5d5t01qg%2BPzF5nPCkpKKjJJs82Ck%2BT%2F5w6EptrINXaFbzjOE2MgYGO0qDIfwXdrAvRSC86LEhspth85uGkluD61qt3aFtkVbCaejUc8pH4V%2Bz%2FUMfE8u6SqjS3g5vMkzlwX5ft2PvA%3D%3D--2zMrgvl3TUqqyaqQ--ndtC4bRPGo3xrpxTGkuLzQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2064107878.1753646133; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 19:55:33 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 19:55:33 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E8CC:1A1F38:1166062:16C602C:68868435
Update NodeAutocomplete search criteria to also include nodes keywords and description by zeusongit · Pull Request #11613 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Update NodeAutocomplete search criteria to also include nodes keywords and description #11613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason this uses its own search instead of the search code that already exists for in canvas and library search? |
|
@zeusongit Did you made any comparison of in-canvas search yet? I am not sure if string comparison of these three cates will be a 100% match, I think originally we were leaning towards to just reuse the existing search code in in-canvas search. |
|
@mjkkirschner The in canvas and library searches are conducted on complete set of nodes, whereas this is done on a subset of that, which is defined by the target input port i.e all the nodes which are compatible with it. |
QilongTang
reviewed
Apr 20, 2021
QilongTang
reviewed
Apr 20, 2021
| @@ -349,7 +349,7 @@ public void SearchNodeAutocompletionSuggestions() | |||
|
|
|||
| // Filter the node elements using the search field. | |||
| searchViewModel.SearchAutoCompleteCandidates("ar"); | |||
| Assert.AreEqual(2 , searchViewModel.FilteredResults.Count()); | |||
| Assert.AreEqual(4 , searchViewModel.FilteredResults.Count()); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeusongit Looks like the number diff is expected due to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the search term ar now returns more than 2 results as the search scope has been increased to cover description and keywords.
QilongTang
reviewed
Apr 20, 2021
QilongTang
approved these changes
Apr 21, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
DYN-3357
The node-autocomplete search used only the node name to match the search key. It has been updated to include node's keywords and description as well.
In the example below
radiusis the search key that is present inByFilletnode's description and therefore did not use to appear in the search results before.Before:
After:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo