| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 28 Jul 2025 16:58:27 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=320.994238,conversation_content-fragment;desc="conversation_content fragment";dur=592.869449,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=263.622205,nginx;desc="NGINX";dur=1.231409,glb;desc="GLB";dur=101.347326
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=PwAM8A1hMMJvjVPnh5EStWg9AulkFvkHIIn5y1fTTQKAm3S%2Fv1LJmlawe6cjRRI7G6w9wh35IbLfVfliREaQpSlj4KSyIuhCepeJbabYdGCbaKPvdEk%2FU2fm6Od%2FIJmPmiiCLsfii5bhvZDQMIxa%2BaOf3t653g0ncy%2BwTCPpfKk9MIAX4KjtkL%2BJMBwfp7LN6uxxiyKkAGCLRDxMeFNB0adKm1Jb%2BrNFkkgMCnZjJLrHz%2FRihca8DSu0QTfOYIV09a%2Fyrfz1AIs4V93brPk8tw%3D%3D--de3RHUUS740nbBBs--qvPq2G0rvAuMOO91XAbesg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.938510928.1753721906; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 16:58:26 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 16:58:26 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8728:38B08:1564D:193E4:6887AC32
DYN-2381 Exclude code block nodes from SetArgumentLacing by StudioLE · Pull Request #11294 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-2381 Exclude code block nodes from SetArgumentLacing #11294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmisol
reviewed
Nov 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this PR does what it was asked for, this is not only a problem with Code Block nodes. Python Script nodes suffer the same issue and probably others do.
By taking a look at the code, I could see NodeModel has a property named ArgumentLacing that should be set to LacingStrategy.Disabled when lacing is not supported by the node. Using that, rather than excluding by type like in https://github.com/DynamoDS/Dynamo/pull/11294/files#diff-14fa24535a2d0aa34f993496cc35eb02dbadcffb7576a54cbeef2e9821edba8cR1131, should be the right way to solve this IMO.
|
mmisol
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks @StudioLE
QilongTang
pushed a commit
that referenced
this pull request
Dec 4, 2020
* Exclude code block nodes from SetArgumentLacing * Added test to check code block lacing doesn't change * Restructured code block lacing test * Exclude all LacingStrategy.Disabled nodes from SetArgumentLacing
8 tasks
QilongTang
added a commit
that referenced
this pull request
Dec 4, 2020
…1327) * Exclude code block nodes from SetArgumentLacing * Added test to check code block lacing doesn't change * Restructured code block lacing test * Exclude all LacingStrategy.Disabled nodes from SetArgumentLacing Co-authored-by: Laurence Elsdon <laurence.elsdon@matterlab.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
JIRA: DYN-2381
Exclude Code Block Nodes when setting the lacing by selecting multiple nodes and right clicking on the canvas.
The previous behaviour did nothing but causes some visual anomalies and can be confusing to a user.
Previous Behaviour:
Revised Behaviour
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @QilongTang @mmisol
FYIs
@Amoursol