| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 19:57:39 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=313.454547,conversation_content-fragment;desc="conversation_content fragment";dur=1437.474516,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=290.221959,nginx;desc="NGINX";dur=0.714703,glb;desc="GLB";dur=101.364645
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=SeRAfiINr6KbzK8QFDkftndT4RAO4alxtX3gq6R911lHfby7T9G5wHOprV6cuSec1O3v4DVb57htlX%2Fdh%2FX4ei6vM%2FMKMXzKYRkSvMgK7fDEAU0o%2F6jIHthGsovGKjuYYffkPCeIsMU%2FM4vDuNTszw37YD0QXiaics07%2F3McSR%2BOPoAnkWWz%2BLGJZGq6Wm%2Bh9QoZecONM4cnuSgBBFcrOm0vbAj9ZdjwRD482dIAkyJB5sdN3FmNTCPlFkSjv2aHP36wz3dhTRR99xjoIS%2FvoQ%3D%3D--Uzd4R2zN2HqfH6ky--fLSJwV1zDZlkFZwG%2F7%2FVbQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.523813785.1753646257; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 19:57:37 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 19:57:37 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9078:2EF87B:CBFF08:10B2505:688684B1
Skip primitive type input ports from node-autocomplete by zeusongit · Pull Request #11201 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Skip primitive type input ports from node-autocomplete #11201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
Oct 23, 2020
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Oct 23, 2020
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Oct 26, 2020
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
approved these changes
Oct 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Oct 27, 2020
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
|
@zeusongit Nice job, once the comment updated, I think we can get this in |
aparajit-pratap
approved these changes
Oct 27, 2020
|
@zeusongit Do you mind cherry pick this one to 2.9.0 branch? |
zeusongit
added a commit
that referenced
this pull request
Oct 27, 2020
* Add list of nodes to be skipped * Add test and comments
zeusongit
added a commit
that referenced
this pull request
Oct 27, 2020
* Add list of nodes to be skipped * Add test and comments
zeusongit
pushed a commit
that referenced
this pull request
Oct 27, 2020
This reverts commit 3ae917f.
zeusongit
added a commit
to zeusongit/Dynamo
that referenced
this pull request
Oct 27, 2020
* Add list of nodes to be skipped * Add test and comments
QilongTang
pushed a commit
that referenced
this pull request
Oct 27, 2020
QilongTang
pushed a commit
that referenced
this pull request
Oct 29, 2020
…1219) * Skip primitive type input ports from node-autocomplete (#11201) * Add list of nodes to be skipped * Add test and comments * Add Analytics Coverage for Node AutoComplete (#11209) * add analytics coverage for node autocomplete Open auto complete window Select suggestion * Update NodeAutoCompleteSearchControl.xaml.cs * add tracking to in-canvas search node selection * add track points for in canvas search open/select Co-authored-by: Ashish Aggarwal <ashish.zeus17@gmail.com> Co-authored-by: Ashish Aggarwal <ashish.zeus17@gmail.com>
QilongTang
pushed a commit
that referenced
this pull request
Nov 5, 2020
…Nodeautocomplete and Incanvas search (#11232) (#11235) * Skip primitive type input ports from node-autocomplete (#11201) * Add list of nodes to be skipped * Add test and comments * Add Analytics Coverage for Node AutoComplete (#11209) * add analytics coverage for node autocomplete Open auto complete window Select suggestion * Update NodeAutoCompleteSearchControl.xaml.cs * add tracking to in-canvas search node selection * add track points for in canvas search open/select Co-authored-by: Ashish Aggarwal <ashish.zeus17@gmail.com> * cherrypicking adp code change for node auto Co-authored-by: Ashish Aggarwal <ashish.zeus17@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
DYN-3184
Skip primitive input ports when displaying node autocomplete suggestions.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo
FYIs
@QilongTang