You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added IntegerSlider64Bit that derives from SliderBase<long> to support 64 bit integers
Deserialize a CoreNodeModels.Input.IntegerSlider type from JSON as a CoreNodeModels.Input.IntegerSlider64Bit so that the new 64 bit slider node is instantiated
Serialize 64 bit node back as CoreNodeModels.Input.IntegerSlider type so that new DYN's can be opened by older versions of Dynamo
Deserialize 32 bit integer slider from old XML format as new 64 bit integer slider - This does not seem to be straightforward since in order to not break the API I needed to keep the legacy class, which is why I had to retain the legacy behaviour of xml-based 32 bit integer sliders (to be deserialized as 32 bit). Now only when you save the XML file (when saved as JSON) and reopened, will the slider behave as a 64 bit integer slider node, not before.
@QiltongTang do you know how to change the description of the output port tooltip for a UI node? The only thing remaining in this PR is to change the output port type of the integer slider to report Int64. Int32 is obviously wrong in this case.
@QilongTang there are 2 regressions remaining. I addressed many of them yesterday. Will address the remaining ones today. In the meantime do you have any comments on the rest of the review?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-1085
IntegerSlider64Bit
that derives fromSliderBase<long>
to support 64 bit integersCoreNodeModels.Input.IntegerSlider
type from JSON as aCoreNodeModels.Input.IntegerSlider64Bit
so that the new 64 bit slider node is instantiatedCoreNodeModels.Input.IntegerSlider
type so that new DYN's can be opened by older versions of DynamoDeserialize 32 bit integer slider from old XML format as new 64 bit integer slider- This does not seem to be straightforward since in order to not break the API I needed to keep the legacy class, which is why I had to retain the legacy behaviour of xml-based 32 bit integer sliders (to be deserialized as 32 bit). Now only when you save the XML file (when saved as JSON) and reopened, will the slider behave as a 64 bit integer slider node, not before.Declarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo