You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparajit-pratap
changed the title
convert BigInteger to Int64 wherever possible from Python
Convert BigInteger to Int64 wherever possible from Python
Oct 29, 2019
aparajit-pratap
changed the title
Convert BigInteger to Int64 wherever possible from Python
Convert BigInteger to Int64 when possible from Python
Oct 31, 2019
The DataMarshaler class isn't used anywhere aside from the Python node so I would also support moving it out of DynamoUtilities and into the Python project, to make its purpose more clear. (Doesn't have to be part of this PR.)
Added unit test, addressed review comments about registering the BigInteger marshaling logic only for node output (output marshalers are added only in the DataMarshaler constructor, while input marshalers are added when first initializing the IronPythonEvaluator property).
I haven't moved DataMarshaler to the Python project just yet as @mjkkirschner had some other thoughts on this. Leaving it open for discussion. Aside from this, the PR is ready to be merged.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
https://autodesk.slack.com/archives/CED3BF6C9/p1571942488031200

JIRA: https://jira.autodesk.com/browse/DYN-2262
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo
FYIs
@Dewb