DYN-6967 Crash when placing List selector archi-lab Dynamo nodes in canvas (#15224)

QilongTang · web-flow · commit fd7d21bfa21c · 2024-05-17T13:51:39.000-04:00
diff --git a/src/DynamoCoreWpf/Properties/Resources.Designer.cs b/src/DynamoCoreWpf/Properties/Resources.Designer.cs
diff --git a/src/DynamoCoreWpf/Properties/Resources.en-US.resx b/src/DynamoCoreWpf/Properties/Resources.en-US.resx
@@ -582,7 +582,7 @@ Don't worry, you'll have the option to save your work.</value>
     <value>_Select All</value>
     <comment>Edit menu | Select all nodes</comment>
   </data>
-    <data name="DynamoViewEditMenuUnpinAllPreviewBubbles" xml:space="preserve">
+  <data name="DynamoViewEditMenuUnpinAllPreviewBubbles" xml:space="preserve">
     <value>_Unpin All Preview Bubbles</value>
     <comment>Edit menu | Unpin preview bubbles</comment>
   </data>
@@ -3983,4 +3983,7 @@ To make this file into a new template, save it to a different folder, then move
   <data name="MessagePackOlderDynamoLink" xml:space="preserve">
     <value>#Learn more=https://primer2.dynamobim.org/1_developer_primer_intro/3_developing_for_dynamo/updating-your-packages-and-dynamo-libraries-for-dynamo-3x-net8</value>
   </data>
-</root>
+  <data name="NodeInCanvasSearchCreationError" xml:space="preserve">
+    <value>Failed to create node: </value>
+  </data>
+</root>
diff --git a/src/DynamoCoreWpf/Properties/Resources.resx b/src/DynamoCoreWpf/Properties/Resources.resx
@@ -330,7 +330,7 @@
     <value>_Select All</value>
     <comment>Edit menu | Select all nodes</comment>
   </data>
-    <data name="DynamoViewEditMenuUnpinAllPreviewBubbles" xml:space="preserve">
+  <data name="DynamoViewEditMenuUnpinAllPreviewBubbles" xml:space="preserve">
     <value>_Unpin All Preview Bubbles</value>
     <comment>Edit menu | Unpin preview bubbles</comment>
   </data>
@@ -3970,4 +3970,7 @@ To make this file into a new template, save it to a different folder, then move
   <data name="MessagePackOlderDynamoLink" xml:space="preserve">
     <value>#Learn more=https://primer2.dynamobim.org/1_developer_primer_intro/3_developing_for_dynamo/updating-your-packages-and-dynamo-libraries-for-dynamo-3x-net8</value>
   </data>
-</root>
+  <data name="NodeInCanvasSearchCreationError" xml:space="preserve">
+    <value>Failed to create node: </value>
+  </data>
+</root>
diff --git a/src/DynamoCoreWpf/PublicAPI.Unshipped.txt b/src/DynamoCoreWpf/PublicAPI.Unshipped.txt
@@ -4878,6 +4878,7 @@ static Dynamo.Wpf.Properties.Resources.NodeHelpWindowNodeDescription.get -> stri
 static Dynamo.Wpf.Properties.Resources.NodeHelpWindowNodeInput.get -> string
 static Dynamo.Wpf.Properties.Resources.NodeHelpWindowNodeOutput.get -> string
 static Dynamo.Wpf.Properties.Resources.NodeHelpWindowNodeType.get -> string
+static Dynamo.Wpf.Properties.Resources.NodeInCanvasSearchCreationError.get -> string
 static Dynamo.Wpf.Properties.Resources.NodeInfoDismissButtonToolTip.get -> string
 static Dynamo.Wpf.Properties.Resources.NodeInformationalStateDismiss.get -> string
 static Dynamo.Wpf.Properties.Resources.NodeInformationalStateDismissAll.get -> string
diff --git a/src/DynamoCoreWpf/ViewModels/Search/NodeSearchElementViewModel.cs b/src/DynamoCoreWpf/ViewModels/Search/NodeSearchElementViewModel.cs
@@ -362,8 +362,19 @@ protected virtual void OnClicked()
         {
             if (Clicked != null)
             {
-                var nodeModel = Model.CreateNode();
-                Clicked(nodeModel, Position);
+                // Try to create the node based on the search element from in-Canvas search
+                // The node creation can fail if the node constructor dependencies are not found or other reasons.
+                // This is a best effort to create the node and log the error both in console and toast notification if it fails.
+                try
+                {
+                    var nodeModel = Model.CreateNode();
+                    Clicked(nodeModel, Position);
+                }
+                catch (Exception ex)
+                {
+                    searchViewModel.dynamoViewModel.Model.Logger.Log("Failed to create node from search element: " + Model.Name + "\n" + ex.Message);
+                    searchViewModel.dynamoViewModel.MainGuideManager.CreateRealTimeInfoWindow(Wpf.Properties.Resources.NodeInCanvasSearchCreationError + Model.Name, true);
+                }
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -362,8 +362,19 @@ protected virtual void OnClicked()`
`362`	`362`	`{`
`363`	`363`	`if (Clicked != null)`
`364`	`364`	`{`
`365`		`- var nodeModel = Model.CreateNode();`
`366`		`- Clicked(nodeModel, Position);`
	`365`	`+ // Try to create the node based on the search element from in-Canvas search`
	`366`	`+ // The node creation can fail if the node constructor dependencies are not found or other reasons.`
	`367`	`+ // This is a best effort to create the node and log the error both in console and toast notification if it fails.`
	`368`	`+ try`
	`369`	`+ {`
	`370`	`+ var nodeModel = Model.CreateNode();`
	`371`	`+ Clicked(nodeModel, Position);`
	`372`	`+ }`
	`373`	`+ catch (Exception ex)`
	`374`	`+ {`
	`375`	`+ searchViewModel.dynamoViewModel.Model.Logger.Log("Failed to create node from search element: " + Model.Name + "\n" + ex.Message);`
	`376`	`+ searchViewModel.dynamoViewModel.MainGuideManager.CreateRealTimeInfoWindow(Wpf.Properties.Resources.NodeInCanvasSearchCreationError + Model.Name, true);`
	`377`	`+ }`
`367`	`378`	`}`
`368`	`379`	`}`
`369`	`380`