[DYN-7436] Dynamo crashes upon exporting results if the destination file is (#15545)

ivaylo-matov · web-flow · commit aa9cb1b72c1f · 2024-10-14T09:31:38.000-07:00
diff --git a/src/DynamoCoreWpf/Properties/Resources.Designer.cs b/src/DynamoCoreWpf/Properties/Resources.Designer.cs
diff --git a/src/DynamoCoreWpf/Properties/Resources.en-US.resx b/src/DynamoCoreWpf/Properties/Resources.en-US.resx
@@ -1267,6 +1267,14 @@ Would you like to save your changes?</value>
 
 Would you like to save your changes?</value>
   </data>
+  <data name="MessageFileInUseByApplication" xml:space="preserve">
+    <value>The file is currently in use by another application.
+	
+Please close the file before trying to overwrite it.</value>
+  </data>
+  <data name="TitleFileInUse" xml:space="preserve">
+    <value>File in use</value>
+  </data>
   <data name="MessageConfirmToSaveNamedHomeWorkSpace" xml:space="preserve">
     <value>You have unsaved changes to {0}.
 
diff --git a/src/DynamoCoreWpf/Properties/Resources.resx b/src/DynamoCoreWpf/Properties/Resources.resx
@@ -935,6 +935,14 @@ Would you like to save your changes?</value>
 
 Would you like to save your changes?</value>
   </data>
+  <data name="MessageFileInUseByApplication" xml:space="preserve">
+    <value>The file is currently in use by another application.
+	
+Please close the file before trying to overwrite it.</value>
+  </data>
+  <data name="TitleFileInUse" xml:space="preserve">
+    <value>File in use</value>
+  </data>
   <data name="MessageConfirmToSaveNamedHomeWorkSpace" xml:space="preserve">
     <value>You have unsaved changes to {0}.
 
diff --git a/src/DynamoCoreWpf/PublicAPI.Unshipped.txt b/src/DynamoCoreWpf/PublicAPI.Unshipped.txt
@@ -4866,6 +4866,7 @@ static Dynamo.Wpf.Properties.Resources.MessageFailedToOpenCorruptedFile.get -> s
 static Dynamo.Wpf.Properties.Resources.MessageFailedToSaveAsImage.get -> string
 static Dynamo.Wpf.Properties.Resources.MessageFailedToUnload.get -> string
 static Dynamo.Wpf.Properties.Resources.MessageFailToUninstallPackage.get -> string
+static Dynamo.Wpf.Properties.Resources.MessageFileInUseByApplication.get -> string
 static Dynamo.Wpf.Properties.Resources.MessageForceInstallOrUninstallToContinue.get -> string
 static Dynamo.Wpf.Properties.Resources.MessageForceInstallOrUninstallUponRestart.get -> string
 static Dynamo.Wpf.Properties.Resources.MessageGettingNodeError.get -> string
@@ -5460,6 +5461,7 @@ static Dynamo.Wpf.Properties.Resources.TabFileNameReadOnlyPrefix.get -> string
 static Dynamo.Wpf.Properties.Resources.TermsOfUseAcceptButton.get -> string
 static Dynamo.Wpf.Properties.Resources.TermsOfUseDeclineButton.get -> string
 static Dynamo.Wpf.Properties.Resources.TermsOfUseViewTitle.get -> string
+static Dynamo.Wpf.Properties.Resources.TitleFileInUse.get -> string
 static Dynamo.Wpf.Properties.Resources.TitlePackageTargetOtherHost.get -> string
 static Dynamo.Wpf.Properties.Resources.TooltipCurrentIndex.get -> string
 static Dynamo.Wpf.Properties.Resources.TourLabelProgressText.get -> string
diff --git a/src/GraphNodeManagerViewExtension/Utilities/Utilities.cs b/src/GraphNodeManagerViewExtension/Utilities/Utilities.cs
@@ -2,8 +2,11 @@
 using System.Data;
 using System.IO;
 using System.Linq;
+using System.Windows;
 using System.Windows.Forms;
 using System.Xml;
+using Dynamo.Wpf.Utilities;
+using Dynamo.Wpf.Properties;
 using Newtonsoft.Json;
 
 namespace Dynamo.GraphNodeManager.Utilities
@@ -30,6 +33,17 @@ public static void ExportToCSV(object exportObject, string promptName)
 
                 if (saveFileDialog.ShowDialog() == DialogResult.OK)
                 {
+                    if (IsFileLocked(new FileInfo(saveFileDialog.FileName)))
+                    {
+                        MessageBoxService.Show(
+                            Resources.MessageFileInUseByApplication,
+                            Resources.TitleFileInUse,
+                            MessageBoxButton.OK,
+                            MessageBoxImage.Warning);
+
+                        return;
+                    }
+
                     string output = JsonConvert.SerializeObject(exportObject);
 
                     var csv = jsonToCSV(output);
@@ -107,5 +121,30 @@ public static List<string> jsonToCSV(string jsonContent)
             lines.AddRange(valueLines);
             return lines;
         }
+
+        /// <summary>
+        /// Checks if the specified file is locked by another process or application.
+        /// </summary>
+        private static bool IsFileLocked(FileInfo file)
+        {
+            if (!file.Exists) return false;
+
+            FileStream stream = null;
+
+            try
+            {
+                stream = file.Open(FileMode.Open, FileAccess.ReadWrite, FileShare.None);
+            }
+            catch (IOException)
+            {
+                return true;
+            }
+            finally
+            {
+                stream?.Close();
+            }
+
+            return false;
+        }
     }
 }
