DYN-6259 Fix Handling preferences bearing in mind the hosts (#14427)

jesusalvino · Jesus Alfredo Alviño · web-flow · commit 8a39ec1d963d · 2023-09-21T21:13:05.000-04:00
* Fix Handling preferences bearing in mind the hosts

* Creating the Preferences on demand

---------

Co-authored-by: Jesus Alfredo Alviño &lt;jesus.alfredo.alvino@autodesk.com&gt;
diff --git a/src/DynamoCore/Models/DynamoModel.cs b/src/DynamoCore/Models/DynamoModel.cs
@@ -678,7 +678,7 @@ protected DynamoModel(IStartConfiguration config)
 
             OnRequestUpdateLoadBarStatus(new SplashScreenLoadEventArgs(Resources.SplashScreenInitPreferencesSettings, 30));
 
-            PreferenceSettings = CreatePreferences(config);
+            PreferenceSettings = (PreferenceSettings)CreateOrLoadPreferences(config.Preferences);
             if (PreferenceSettings != null)
             {
                 PreferenceSettings.PropertyChanged += PreferenceSettings_PropertyChanged;
@@ -1048,29 +1048,6 @@ internal PathManager CreatePathManager(IStartConfiguration config)
             }
         }
 
-        /// <summary>
-        /// It returns a PreferenceSettings instance based on the mode in order to reuse it's Singleton instance or create a new one
-        /// </summary>
-        /// <param name="config"></param>
-        /// <returns></returns>
-        internal PreferenceSettings CreatePreferences(IStartConfiguration config)
-        {
-            PreferenceSettings preferences = null;
-            if (!config.StartInTestMode)
-            {
-                if (config.Preferences is PreferenceSettings settings)
-                {
-                    preferences = settings;
-                }
-            }
-            else
-            {
-                preferences = (PreferenceSettings)CreateOrLoadPreferences(config.Preferences);
-            }
-
-            return preferences;
-        }
-
         /// <summary>
         /// Create or load a preference checking the usage mode and if it already exists
         /// </summary>
