DYN-9999 : dna filtering improvements (#16281)

BogdanZavu · zavub · web-flow · commit 71846e9550c9 · 2025-06-11T09:57:15.000-04:00
Co-authored-by: Bogdan Zavu &lt;bogdan.zavu@autodesk.com&gt;
diff --git a/src/DynamoCoreWpf/PublicAPI.Unshipped.txt b/src/DynamoCoreWpf/PublicAPI.Unshipped.txt
@@ -373,6 +373,10 @@ Dynamo.Controls.LeftThicknessConverter
 Dynamo.Controls.LeftThicknessConverter.Convert(object value, System.Type targetType, object parameter, System.Globalization.CultureInfo culture) -> object
 Dynamo.Controls.LeftThicknessConverter.ConvertBack(object value, System.Type targetType, object parameter, System.Globalization.CultureInfo culture) -> object
 Dynamo.Controls.LeftThicknessConverter.LeftThicknessConverter() -> void
+Dynamo.Controls.LengthToVisibilityConverter
+Dynamo.Controls.LengthToVisibilityConverter.Convert(object value, System.Type targetType, object parameter, System.Globalization.CultureInfo culture) -> object
+Dynamo.Controls.LengthToVisibilityConverter.ConvertBack(object value, System.Type targetType, object parameter, System.Globalization.CultureInfo culture) -> object
+Dynamo.Controls.LengthToVisibilityConverter.LengthToVisibilityConverter() -> void
 Dynamo.Controls.LibraryTreeItemsHostVisibilityConverter
 Dynamo.Controls.LibraryTreeItemsHostVisibilityConverter.Convert(object value, System.Type targetType, object parameter, System.Globalization.CultureInfo culture) -> object
 Dynamo.Controls.LibraryTreeItemsHostVisibilityConverter.ConvertBack(object value, System.Type targetType, object parameter, System.Globalization.CultureInfo culture) -> object
diff --git a/src/DynamoCoreWpf/UI/Converters.cs b/src/DynamoCoreWpf/UI/Converters.cs
@@ -4310,4 +4310,20 @@ public object ConvertBack(object value, Type targetType, object parameter, Cultu
             return Binding.DoNothing;
         }
     }
+
+    public class LengthToVisibilityConverter : IValueConverter
+    {
+        public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
+        {
+            if (value is int length)
+                return length > 0 ? Visibility.Collapsed : Visibility.Visible;
+
+            return Visibility.Visible;
+        }
+
+        public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
+        {
+            throw new NotImplementedException();
+        }
+    }
 }
diff --git a/src/DynamoCoreWpf/UI/Themes/Modern/DynamoConverters.xaml b/src/DynamoCoreWpf/UI/Themes/Modern/DynamoConverters.xaml
@@ -176,4 +176,5 @@
     <controls:PortTypeToStringConverter x:Key="PortTypeToStringConverter" />
     <controls:BooleanNegationConverter x:Key="BooleanNegationConverter" />
     <controls:LeftMarginConverter x:Key="LeftMarginConverter" />
+    <controls:LengthToVisibilityConverter x:Key="LengthToVisibilityConverter" />
 </ResourceDictionary>
diff --git a/src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs b/src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs
@@ -191,7 +191,7 @@ public bool IsOpen
             }
         }
 
-        private int ClusterResultsCount => DropdownResults == null ? 0 : DropdownResults.Count();
+        private int ClusterResultsCount => FilteredView == null ? 0 : FilteredView.Cast<object>().ToList().Count;
 
         private int selectedIndex = 0;
 
@@ -231,6 +231,8 @@ public string SearchInput
                 {                    
                     FilteredView.Refresh();
                 }
+
+                RaisePropertyChanged(nameof(SearchInput));
             }
         }
 
@@ -245,30 +247,19 @@ public int SelectedIndex
             }
             set
             {
-                /*don't try to add a node if the index is out of range or a selection is not made yet (-1)
-                an index of -1 occurs when using the switch to change between modes.*/
-                if (selectedIndex != value && value >= 0 && selectedIndex != -1)
+                if (selectedIndex != value && value >= -1)
                 {
-                    ReAddNode(value);
-                }
-                selectedIndex = value;
-                RaisePropertyChanged(nameof(SelectedIndex));
-                RaisePropertyChanged(nameof(NthofTotal));
-                RaisePropertyChanged(nameof(PreviousSource));
-                RaisePropertyChanged(nameof(NextSource));
-            }
-        }
+                    selectedIndex = value;
+                    if (selectedIndex != -1)
+                    {
+                        AddCluster(selectedIndex);
+                    }
 
-        private void ReAddNode(int index)
-        {
-            if(FullResults == null)
-            {
-                return;
-            }
-            var results = QualifiedResults.ToList();
-            if(index >=  0 && index  < results.Count)
-            {
-                AddCluster(results[index]);
+                    RaisePropertyChanged(nameof(SelectedIndex));
+                    RaisePropertyChanged(nameof(NthofTotal));
+                    RaisePropertyChanged(nameof(PreviousSource));
+                    RaisePropertyChanged(nameof(NextSource));
+                }
             }
         }
 
@@ -426,6 +417,7 @@ internal void ResetAutoCompleteSearchViewState()
             FilteredResults = new List<NodeSearchElementViewModel>();
             FilteredHighConfidenceResults = new List<NodeSearchElementViewModel>();
             FilteredLowConfidenceResults = new List<NodeSearchElementViewModel>();
+            SearchInput = string.Empty;            
         }
 
         internal MLNodeAutoCompletionRequest GenerateRequestForMLAutocomplete()
@@ -796,6 +788,19 @@ internal void DeleteTransientNodes()
             }
         }
 
+
+        internal void AddCluster(int filterredIndex)
+        {
+            var currentFilter = FilteredView.Cast<DNADropdownViewModel>().ToList();
+            var currentItem = filterredIndex >= 0 && filterredIndex < currentFilter.Count ? currentFilter[filterredIndex] : null;
+
+            var realCluster = QualifiedResults.FirstOrDefault(x => x.Description.Equals(currentItem.Description));
+            if (realCluster != null)
+            {
+                AddCluster(realCluster);
+            }
+        }
+
         // Add Cluster from server result into the workspace
         internal void AddCluster(ClusterResultItem clusterResultItem)
         {
@@ -1040,8 +1045,6 @@ internal void PopulateAutoComplete()
                     if (comboboxResults.Any())
                     {
                         SelectedIndex = 0;
-                        var ClusterResultItem = QualifiedResults.First();
-                        AddCluster(ClusterResultItem);
                     }
                     
                 });
diff --git a/src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml b/src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml
@@ -6,6 +6,7 @@
              xmlns:ui="clr-namespace:Dynamo.UI;assembly=DynamoCoreWpf"
              xmlns:local="clr-namespace:Dynamo.PackageManager.UI;assembly=DynamoCoreWpf"
              xmlns:dynconverters="clr-namespace:Dynamo.Controls;assembly=DynamoCoreWpf"
+             xmlns:resxother="clr-namespace:Dynamo.Wpf.Properties;assembly=DynamoCoreWpf"
              mc:Ignorable="d"
              WindowStyle="None"
              AllowsTransparency="True"
@@ -40,6 +41,7 @@
             </Style>
             <dynconverters:BoolToVisibilityConverter x:Key="BooleanToVisibilityConverter"/>
             <dynconverters:InverseBoolToVisibilityConverter  x:Key="InverseBooleanToVisibilityConverter"/>
+            <dynconverters:LengthToVisibilityConverter  x:Key="LengthToVisibilityConverter"/>
         </ResourceDictionary>
     </Window.Resources>
 
@@ -160,21 +162,48 @@
                                 </Style>
                             </ComboBox.Style>
                             <ComboBox.Tag>
-                                <TextBox x:Name="AutoCompleteSearchBox"                                            
-                                    HorizontalAlignment="Stretch"
-                                    Height="24"
-                                    Margin="16,5,16,5"
-                                    Padding="2"                                                 
-                                    Width="Auto"                                    
-                                    Foreground="{Binding Foreground, RelativeSource={RelativeSource AncestorType=ComboBox}}"
-                                    Background="{Binding Background, RelativeSource={RelativeSource AncestorType=ComboBox}}"
-                                    FontFamily="{Binding FontFamily, RelativeSource={RelativeSource AncestorType=ComboBox}}"
-                                    CaretBrush="{Binding Foreground, RelativeSource={RelativeSource AncestorType=ComboBox}}"
-                                    FontSize="14">
-                                    <TextBox.Text>
-                                        <Binding Path="SearchInput" Mode="OneWayToSource" UpdateSourceTrigger="PropertyChanged" />
-                                    </TextBox.Text>
-                                </TextBox>
+                                <Grid>
+                                    <TextBox x:Name="AutoCompleteSearchBox"                                            
+                                        HorizontalAlignment="Stretch"
+                                        Height="28"
+                                        Margin="7,3,7,3"
+                                        Padding="2"                                                 
+                                        Width="Auto"
+                                        BorderThickness="0,0,0,1"
+                                        Foreground="{Binding Foreground, RelativeSource={RelativeSource AncestorType=ComboBox}}"
+                                        Background="{Binding Background, RelativeSource={RelativeSource AncestorType=ComboBox}}"
+                                        FontFamily="{Binding FontFamily, RelativeSource={RelativeSource AncestorType=ComboBox}}"
+                                        CaretBrush="{Binding Foreground, RelativeSource={RelativeSource AncestorType=ComboBox}}"
+                                        FontSize="14">
+                                        <TextBox.Text>
+                                            <Binding Path="SearchInput" Mode="TwoWay" UpdateSourceTrigger="PropertyChanged" />
+                                        </TextBox.Text>
+                                    </TextBox>
+
+                                    <StackPanel x:Name="PlaceholderPanel"
+                                        Orientation="Horizontal"
+                                        VerticalAlignment="Center"
+                                        IsHitTestVisible="False"
+                                        HorizontalAlignment="Stretch"
+                                        Height="28"
+                                        Margin="12,3,7,3"
+                                        Width="Auto"
+                                        Visibility="{Binding Text.Length, ElementName=AutoCompleteSearchBox, Converter={StaticResource LengthToVisibilityConverter}}">
+                                        <Image x:Name="SearchIcon"
+                                            Width="20px"
+                                            Height="20px"                                            
+                                            HorizontalAlignment="Left"
+                                            VerticalAlignment="Center"
+                                            DockPanel.Dock="Left">
+                                            <Image.Style>
+                                                <Style TargetType="{x:Type Image}">
+                                                    <Setter Property="Source" Value="/DynamoCoreWpf;component/UI/Images/searchmagnifier.png" />
+                                                </Style>
+                                            </Image.Style>
+                                        </Image>
+                                        <TextBlock Padding="2" FontSize="14" Text="{x:Static resxother:Resources.LibraryViewSearchText}" Foreground="{Binding Foreground, RelativeSource={RelativeSource AncestorType=ComboBox}}" VerticalAlignment="Center"/>
+                                    </StackPanel>
+                                </Grid>
                             </ComboBox.Tag>
                             <ComboBox.ItemTemplate>
                                 <DataTemplate>
diff --git a/src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml.cs b/src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml.cs
@@ -75,7 +75,7 @@ private void GripHandle_MouseLeftButtonDown(object sender, MouseButtonEventArgs
 
         private void MoveIndex(int step)
         {
-            ViewModel.SelectedIndex = Math.Min(ViewModel.DropdownResults.Count() - 1, Math.Max(0, ViewModel.SelectedIndex + step));
+            ViewModel.SelectedIndex = Math.Min(ViewModel.FilteredView.Cast<object>().Count() - 1, Math.Max(0, ViewModel.SelectedIndex + step));
         }
 
         private void PrevButton_OnClick(object sender, RoutedEventArgs e)

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ public bool IsOpen`
`191`	`191`	`}`
`192`	`192`	`}`
`193`	`193`
`194`		`- private int ClusterResultsCount => DropdownResults == null ? 0 : DropdownResults.Count();`
	`194`	`+ private int ClusterResultsCount => FilteredView == null ? 0 : FilteredView.Cast<object>().ToList().Count;`
`195`	`195`
`196`	`196`	`private int selectedIndex = 0;`
`197`	`197`
`@@ -231,6 +231,8 @@ public string SearchInput`
`231`	`231`	`{`
`232`	`232`	`FilteredView.Refresh();`
`233`	`233`	`}`
	`234`	`+`
	`235`	`+ RaisePropertyChanged(nameof(SearchInput));`
`234`	`236`	`}`
`235`	`237`	`}`
`236`	`238`
`@@ -245,30 +247,19 @@ public int SelectedIndex`
`245`	`247`	`}`
`246`	`248`	`set`
`247`	`249`	`{`
`248`		`- /*don't try to add a node if the index is out of range or a selection is not made yet (-1)`
`249`		`- an index of -1 occurs when using the switch to change between modes.*/`
`250`		`- if (selectedIndex != value && value >= 0 && selectedIndex != -1)`
	`250`	`+ if (selectedIndex != value && value >= -1)`
`251`	`251`	`{`
`252`		`- ReAddNode(value);`
`253`		`- }`
`254`		`- selectedIndex = value;`
`255`		`- RaisePropertyChanged(nameof(SelectedIndex));`
`256`		`- RaisePropertyChanged(nameof(NthofTotal));`
`257`		`- RaisePropertyChanged(nameof(PreviousSource));`
`258`		`- RaisePropertyChanged(nameof(NextSource));`
`259`		`- }`
`260`		`- }`
	`252`	`+ selectedIndex = value;`
	`253`	`+ if (selectedIndex != -1)`
	`254`	`+ {`
	`255`	`+ AddCluster(selectedIndex);`
	`256`	`+ }`
`261`	`257`
`262`		`- private void ReAddNode(int index)`
`263`		`- {`
`264`		`- if(FullResults == null)`
`265`		`- {`
`266`		`- return;`
`267`		`- }`
`268`		`- var results = QualifiedResults.ToList();`
`269`		`- if(index >= 0 && index < results.Count)`
`270`		`- {`
`271`		`- AddCluster(results[index]);`
	`258`	`+ RaisePropertyChanged(nameof(SelectedIndex));`
	`259`	`+ RaisePropertyChanged(nameof(NthofTotal));`
	`260`	`+ RaisePropertyChanged(nameof(PreviousSource));`
	`261`	`+ RaisePropertyChanged(nameof(NextSource));`
	`262`	`+ }`
`272`	`263`	`}`
`273`	`264`	`}`
`274`	`265`
`@@ -426,6 +417,7 @@ internal void ResetAutoCompleteSearchViewState()`
`426`	`417`	`FilteredResults = new List<NodeSearchElementViewModel>();`
`427`	`418`	`FilteredHighConfidenceResults = new List<NodeSearchElementViewModel>();`
`428`	`419`	`FilteredLowConfidenceResults = new List<NodeSearchElementViewModel>();`
	`420`	`+ SearchInput = string.Empty;`
`429`	`421`	`}`
`430`	`422`
`431`	`423`	`internal MLNodeAutoCompletionRequest GenerateRequestForMLAutocomplete()`
`@@ -796,6 +788,19 @@ internal void DeleteTransientNodes()`
`796`	`788`	`}`
`797`	`789`	`}`
`798`	`790`
	`791`	`+`
	`792`	`+ internal void AddCluster(int filterredIndex)`
	`793`	`+ {`
	`794`	`+ var currentFilter = FilteredView.Cast<DNADropdownViewModel>().ToList();`
	`795`	`+ var currentItem = filterredIndex >= 0 && filterredIndex < currentFilter.Count ? currentFilter[filterredIndex] : null;`
	`796`	`+`
	`797`	`+ var realCluster = QualifiedResults.FirstOrDefault(x => x.Description.Equals(currentItem.Description));`
	`798`	`+ if (realCluster != null)`
	`799`	`+ {`
	`800`	`+ AddCluster(realCluster);`
	`801`	`+ }`
	`802`	`+ }`
	`803`	`+`
`799`	`804`	`// Add Cluster from server result into the workspace`
`800`	`805`	`internal void AddCluster(ClusterResultItem clusterResultItem)`
`801`	`806`	`{`
`@@ -1040,8 +1045,6 @@ internal void PopulateAutoComplete()`
`1040`	`1045`	`if (comboboxResults.Any())`
`1041`	`1046`	`{`
`1042`	`1047`	`SelectedIndex = 0;`
`1043`		`- var ClusterResultItem = QualifiedResults.First();`
`1044`		`- AddCluster(ClusterResultItem);`
`1045`	`1048`	`}`
`1046`	`1049`
`1047`	`1050`	`});`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ private void GripHandle_MouseLeftButtonDown(object sender, MouseButtonEventArgs`
`75`	`75`
`76`	`76`	`private void MoveIndex(int step)`
`77`	`77`	`{`
`78`		`- ViewModel.SelectedIndex = Math.Min(ViewModel.DropdownResults.Count() - 1, Math.Max(0, ViewModel.SelectedIndex + step));`
	`78`	`+ ViewModel.SelectedIndex = Math.Min(ViewModel.FilteredView.Cast<object>().Count() - 1, Math.Max(0, ViewModel.SelectedIndex + step));`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`private void PrevButton_OnClick(object sender, RoutedEventArgs e)`