| CARVIEW |
Select Language
HTTP/2 200
accept-ranges: bytes
content-type: text/html; charset=UTF-8
set-cookie: Bugzilla_login_request_cookie=eU9rNSnXM0vD; path=/; secure; HttpOnly; SameSite=Lax
set-cookie: github_token=ldJTgjHSpv7KL017rXDIDpTB6kcxHIhOgk4KG8U9saTT3YkLZHivq9y5WF6D4looESOO30ka1wyR8S2EYR0a4zFVSCgNnnr6i26EEDXfP7vOaPqJVlToP5Ws1txKOGeeAcqMiNryZWIETn3aY4YC1aPAN6IcAmpVeqVfbZQHi1cdLoNIw0Kua6umvafOfnTjAhpAIxK9MsVM7T8kDn9WLLY1ES948rGWyS2wZob4fHvfswZiBhBZuyX6zi3klZ7G; path=/; secure; HttpOnly; SameSite=Lax
via: 1.1 google, 1.1 varnish, 1.1 varnish
x-content-type-options: nosniff
x-xss-protection: 1; mode=block
strict-transport-security: max-age=31536000; includeSubDomains
content-encoding: gzip
referrer-policy: same-origin
server: nginx
x-frame-options: SAMEORIGIN
content-security-policy: default-src 'self'; worker-src 'none'; connect-src 'self' https://product-details.mozilla.org https://treeherder.mozilla.org/api/failurecount/; font-src 'self' https://fonts.gstatic.com; img-src 'self' data: https://secure.gravatar.com https://bug1957214.bmoattachments.org/; media-src 'self' https://bug1957214.bmoattachments.org/; object-src 'none'; script-src 'self' 'nonce-AuwL9J0QFk9qoOnn4PxRtyf43eL8ImS2OfrGJ7MxvdPi3z3S' 'unsafe-inline' 'unsafe-eval'; style-src 'self' 'unsafe-inline'; frame-src 'self' https://crash-stop-addon.herokuapp.com; frame-ancestors 'self'; form-action 'self' https://www.google.com/search https://github.com/login/oauth/authorize https://github.com/login https://phabricator.services.mozilla.com/ https://people.mozilla.org
date: Sat, 04 Oct 2025 23:47:26 GMT
x-served-by: cache-bom-vanm7210045-BOM, cache-bom-vanm7210045-BOM
x-cache: MISS, MISS
x-cache-hits: 0, 0
x-timer: S1759621646.756336,VS0,VE1217
vary: Accept-Encoding
1957214 - Remove comment that is no longer accurate from Prompter.sys.mjs
Remove comment that is no longer accurate from Prompter
Closed
Bug 1957214
Opened 6 months ago
Closed 2 months ago
Remove comment that is no longer accurate from Prompter.sys.mjs
*
Summary:
Remove comment that is no longer accurate from Prompter.sys.mjs
Categories
(Toolkit :: Content Prompts, task)
Tracking
()
RESOLVED
FIXED
RESOLVED
FIXED
143 Branch
Iteration:
---
| Webcompat Score | |
| a11y-review | |
| Performance Impact | |
| Accessibility Severity | |
| Webcompat Priority |
| Tracking | Status | |
|---|---|---|
| firefox143 | --- | fixed |
| Tracking | Status | |
|---|---|---|
| relnote-firefox | ||
| thunderbird_esr115 | ||
| thunderbird_esr140 | ||
| firefox-esr115 | ||
| firefox-esr140 | ||
| firefox143 | ||
| firefox144 | ||
| firefox145 |
People
(Reporter: gregp, Assigned: mason)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=JS])
---
[lang=JS]
QA Whiteboard:
[qa-triage-done-c144/b143]
Has STR:
---
Change Request:
---
0
Bug Flags:
|
| ||||
Crash Data
Signature:
None
Security
(public)
This bug is publicly visible.
User Story
Attachments
(1 file)
Prompter.sys.mjs used to create a temporary object (PromptUtilsTemp) that extended PromptUtils.
var PromptUtilsTemp = {
...some extra utility methods
};
Object.setPrototypeOf(PromptUtilsTemp, PromptUtils);
Then PromptUtils would be reassigned to this object.
PromptUtils = PromptUtilsTemp;
This mess was cleaned up in bug 1808172, so this comment is no longer accurate.
// This is redefined below, for strange and unfortunate reasons.
import { PromptUtils } from "resource://gre/modules/PromptUtils.sys.mjs";
To reduce confusion, the comment should be removed.
|
Reporter | |
Comment 1•6 months ago
|
||
Keywords: good-first-bug
Whiteboard: [lang=JS]
|
Assignee | |
Comment 2•3 months ago
|
||
Hey, I'm new and will submit a patch for this soon
|
||
Updated•3 months ago
|
Assignee: nobody → mason
|
|
Assignee | |
Comment 3•3 months ago
|
||
Attached file
Bug 1957214 - Remove inaccurate comment. r?mtigley!
— Details
|
||
Updated•3 months ago
|
Attachment #9499007 -
Attachment description: WIP: Bug 1957214 - Remove comment that is no longer accurate from Prompter.sys.mjs → Bug 1957214 - Remove inaccurate comment. r?mtigley!
|
||
Comment 4•2 months ago
|
||
There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:mason, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.
Flags: needinfo?(mtigley)
Flags: needinfo?(mason)
|
|
||
Comment 5•2 months ago
|
||
I have just landed this on Mason's behalf.
Flags: needinfo?(mtigley)
Flags: needinfo?(mason)
Pushed by scunnane@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/8df97b9e04f8
https://hg.mozilla.org/integration/autoland/rev/78c096b0950c
Remove inaccurate comment. r=mtigley DONTBUILD
|
||
Comment 7•2 months ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox143:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
|
||
Updated•1 months ago
|
QA Whiteboard: [qa-triage-done-c144/b143]
You need to log in
before you can comment on or make changes to this bug.
Description
•