fix: Remove rc-config-loader (#11)

HeRoMo · web-flow · commit 89829243f045 · 2021-07-01T20:59:41.000+09:00
* remove rc-config-loader

* add js-yaml to dependencies

* remove js file support

* improve code

* add comment

* Update node-version

* remove no-use code
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [10, 12, 14]
+        node-version: [ 12, 14, 16 ]
     steps:
       - name: checkout
         uses: actions/checkout@v2
diff --git a/README.md b/README.md
@@ -33,7 +33,8 @@ Via `.textlintrc`(Recommended)
 - `allowlistConfigPaths`: `string[]`
     - File path list that includes allow words.
     - The File path is relative path from your `.textlintrc`.
-    - Support file format: JSON, yml, js
+    - Support file format: JSON, yml
+    - Cannot use when using [@textlint/editor](https://github.com/textlint/editor)
 
 For example, you can specify `allowlistConfigPaths` to `.textlintrc`.
 
diff --git a/package.json b/package.json
@@ -49,7 +49,7 @@
     "@textlint/ast-node-types": "^12.0.0",
     "@textlint/get-config-base-dir": "^2.0.0",
     "@textlint/regexp-string-matcher": "^1.1.0",
-    "rc-config-loader": "^4.0.0"
+    "js-yaml": "^4.1.0"
   },
   "peerDependencies": {
     "textlint": ">= 9.0.0"
diff --git a/src/textlint-filter-rule-allowlist.js b/src/textlint-filter-rule-allowlist.js
@@ -1,17 +1,28 @@
 import path from "path";
-import { rcFile } from "rc-config-loader";
+import yaml from "js-yaml";
 import { getConfigBaseDir } from "@textlint/get-config-base-dir";
 import { matchPatterns } from "@textlint/regexp-string-matcher";
 
+const loadAllowlistConfigFile = (baseDirectory, filePath) => {
+    // It is for suppoting browser bundler.
+    const fs = require("fs");
+    const configFilePath = path.resolve(baseDirectory, filePath);
+    const extName = path.extname(configFilePath);
+    const configFile = fs.readFileSync(configFilePath);
+    if (extName == ".json") {
+        return JSON.parse(configFile);
+    } else if (/\.(yml|yaml)$/.test(extName)) {
+        return yaml.load(configFile);
+    }
+    throw new Error(`Unsupported file type: ${filePath}`);
+};
+
 const getAllowWordsFromFiles = (files, baseDirectory) => {
     let results = [];
     files.forEach((filePath) => {
-        // TODO: use other loader
-        const contents = rcFile("file", {
-            configFileName: path.resolve(baseDirectory, filePath)
-        });
-        if (contents && Array.isArray(contents.config)) {
-            results = results.concat(contents.config);
+        const config = loadAllowlistConfigFile(baseDirectory, filePath);
+        if (config && Array.isArray(config)) {
+            results = results.concat(config);
         } else {
             throw new Error(`This allow file is not allow word list: ${filePath}`);
         }
diff --git a/yarn.lock b/yarn.lock
@@ -2736,7 +2736,7 @@ js-yaml@4.0.0:
   dependencies:
     argparse "^2.0.1"
 
-js-yaml@4.1.0, js-yaml@^4.0.0:
+js-yaml@4.1.0, js-yaml@^4.1.0:
   version "4.1.0"
   resolved "https://registry.yarnpkg.com/js-yaml/-/js-yaml-4.1.0.tgz#c1fb65f8f5017901cdd2c951864ba18458a10602"
   integrity sha512-wpxZs9NoxZaJESJGIZTyDEaYpl0FKSA+FB9aJiyemKhMwkxQg63h4T1KJgUGHpTqPDNRcmmYLugrRjJlBtWvRA==
@@ -3884,16 +3884,6 @@ rc-config-loader@^3.0.0:
     json5 "^2.1.1"
     require-from-string "^2.0.2"
 
-rc-config-loader@^4.0.0:
-  version "4.0.0"
-  resolved "https://registry.yarnpkg.com/rc-config-loader/-/rc-config-loader-4.0.0.tgz#144cf31961c9f8ebcf252bd9c263fd40d62bd387"
-  integrity sha512-//LRTblJEcqbmmro1GCmZ39qZXD+JqzuD8Y5/IZU3Dhp3A1Yr0Xn68ks8MQ6qKfKvYCWDveUmRDKDA40c+sCXw==
-  dependencies:
-    debug "^4.1.1"
-    js-yaml "^4.0.0"
-    json5 "^2.1.2"
-    require-from-string "^2.0.2"
-
 read-pkg-up@^1.0.1:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/read-pkg-up/-/read-pkg-up-1.0.1.tgz#9d63c13276c065918d57f002a57f40a1b643fb02"
