| CARVIEW |
Select Language
HTTP/2 302
date: Sun, 20 Jul 2025 22:30:54 GMT
content-length: 0
location: https://github.com/spring-projects/spring-tools/pull/988
server-timing: nginx;desc="NGINX";dur=0.765934,glb;desc="GLB";dur=94.824911
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=lyWkNCI9WoHBo2A20Jj0prLbyzNhvV0PGsz4earJ4b8i8Jq0u%2BL7E6F51O3Lkyt%2B87q%2B8QTbyv1kmEDQEeahaLM00yguJfBH%2FFo9osR7NKYdPeh1M7mlN3Gd0XZXCtLu8OpygDhgZiV44o3Ba%2FkTS5daWhcOV1QA6crIlV7gDTiUx%2FwmbVV4hw%2Fd6IcDtZ70p1hg%2BQn%2F2EjnaVtGmYCcKkqPvj3Z8Yg8TbxLcEGzqZ1zRhZyRco0adD3MG%2FWIdk1p0TN8%2B%2FzGNoniJvmHPfyGw%3D%3D--HrJNLMkJPJcrVL%2Bq--xyJsV3kUIHjeFV8bWmFrCQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.550434848.1753050654; Path=/; Domain=github.com; Expires=Mon, 20 Jul 2026 22:30:54 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 20 Jul 2026 22:30:54 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A20C:21415F:11BA601:16ECAAA:687D6E1E
HTTP/2 200
date: Sun, 20 Jul 2025 22:30:55 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=326.185788,conversation_content-fragment;desc="conversation_content fragment";dur=439.16806,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=215.044329,nginx;desc="NGINX";dur=1.42593,glb;desc="GLB";dur=95.386941
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: A20C:21415F:11BA61C:16ECAD3:687D6E1E
completions for predicate keywords in Spring Data repositories by danthe1st · Pull Request #988 · spring-projects/spring-tools · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 211
completions for predicate keywords in Spring Data repositories #988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am unsure whether to actually use |
|
@danthe1st property completion kind for property is more appropriate. As for the query (method name) maybe text is fine... The completion kind only affects the icon description that is supposed to tell you what about to follow once completion item is applied. Since the result is just text the text completion kind seems ok to me. |
|
@BoykoAlex |
|
Merged with 2e79692 (@danthe1st hmm... the result of the completion is just text, correct? I think in this case it should just remain text) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR adds completions for predicate keywords in Spring Data repositories.
For example, it would suggest a completion
findByFirstNameAndwhen typingfindByFirstName.This is a follow-up to #981.
With this PR, it should now be possible to create most Spring JPA repository methods just with Content assist proposals (and adjusting the return type if wanted).