| CARVIEW |
Select Language
HTTP/2 302
date: Sun, 20 Jul 2025 12:45:09 GMT
content-length: 0
location: https://github.com/spring-projects/spring-tools/pull/464
server-timing: nginx;desc="NGINX";dur=1.07357,glb;desc="GLB";dur=96.325486
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=kOQjsgClbZuUyDr8FotChcpy5Y9Dbb1ulLYKAxuWJW%2BN9TyZB9HsOYjCTlHqXpf9zBCiGGwDF80V9HBEnYO167CMOlFHbKaNc8BqADJeLgKixU3RmfjbIiOIfBEGxZbcKMabepEbUD6ChUAoofRXf%2BnwGciqQWU15LETbXFzlTQKjgtLRWSrpiASl9v%2FTTFZIzdsJ%2F8B0TI0eFS094UgQLIkYI8M8qoOMgZgp9xk%2F7mxecXDgTspqrPwtxTkWUo%2BwsjuFP1TOcutrBDbB12Xww%3D%3D--F7KemseTf%2F%2BxsaNQ--jPTR%2BGgynyMH3wJEf6rLPA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.163149850.1753015508; Path=/; Domain=github.com; Expires=Mon, 20 Jul 2026 12:45:08 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 20 Jul 2026 12:45:08 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D7EA:305A02:9A7566:CA129F:687CE4D4
HTTP/2 200
date: Sun, 20 Jul 2025 12:45:10 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=343.237671,conversation_content-fragment;desc="conversation_content fragment";dur=524.719503,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=255.351234,nginx;desc="NGINX";dur=0.611644,glb;desc="GLB";dur=97.269695
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: D7EA:305A02:9A75C0:CA131A:687CE4D4
[concourse] Add support for set-pipeline step by deepakmohanakrishnan07 · Pull Request #464 · spring-projects/spring-tools · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 211
[concourse] Add support for set-pipeline step #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kdvolder
merged 1 commit into
spring-projects:master
from
deepakmohanakrishnan07:concourse/lang/setpipeline
May 19, 2020
Merged
[concourse] Add support for set-pipeline step #464
kdvolder
merged 1 commit into
spring-projects:master
from
deepakmohanakrishnan07:concourse/lang/setpipeline
May 19, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the quality PR. Tests and everything :-) |
|
Started getting some test failures after merging the PR. For example: I'm reverting the merge until I have to time to look into it in detail. |
This was referenced May 19, 2020
kdvolder
added a commit
that referenced
this pull request
May 21, 2020
See #464 Problems found: - issues with formatting of the test case examples. Spaces vs tabs issues and weird indentation of the examples causing problems for editor to parse examples. - added 'set_pipeline' step caused some other tests fail because they should correctly expect this as a valid completion, but tests had not been updated to reflect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Concourse Language Server is used in multiple IDEs, SpringToolSuite, VS. Code, etc., to provide validation, content assist and documentation hovers for editing Concourse Pipeline and Task configuration files.
This PR includes changes to Concourse Language Server to provide the support for set-pipeline pipeline entity syntax highlighting, validation, and doc.