| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 11:25:56 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=362.131717,conversation_content-fragment;desc="conversation_content fragment";dur=1126.954622,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=325.624448,nginx;desc="NGINX";dur=0.526256,glb;desc="GLB";dur=94.52436
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=PSBIXmNogbUR%2BLYOXghACHGfstrNGHKnMegHnJQ5QVNJ6J0gWrYKv3Z8IBAvVlB70sHdAedBEafkPMLJ4qp082NWMw6px%2BdXEUtwn8%2B%2FehWDT4s8r9y6e6B4zz2uADK76UUtamUlv%2FDh2udDC7wnQ2V2Hl1zYCz%2FCHD95WbHdXiPuwRTrNrEofxc%2FnqBpW5wC1iYlTsJ3fTd%2BPADwSEyv0OI4PTSmXbg3cpkk%2BDUQ7jqixvt2yf66Cixo5UeFRBxtxJOBlY8a83weXHywPnQ9Q%3D%3D--qZr%2BQY%2B4U5RMSV3u--P6HJTh%2B80y99oRdRBdQ1zQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.209582037.1752924355; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:25:55 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:25:55 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A05A:0A87:43DFD1:55AEDC:687B80C3
Friendly catch exception when fail to initialize XPU devices by guangyey · Pull Request #141658 · pytorch/pytorch · GitHub
guangyey
added
ciflow/xpu
Run XPU CI tasks
module: xpu
Intel XPU related issues
release notes: xpu
release notes category
labels
Nov 27, 2024
guangyey
changed the title
Friendly catch execption when initialize XPU devices
Friendly catch exception when fail to initialize XPU devices
Nov 27, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Friendly catch exception when fail to initialize XPU devices #141658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141658
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 87d974a with merge base 6e61ff4 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
guangyey
added
ciflow/xpu
EikanWang
reviewed
Nov 27, 2024
c10/xpu/XPUFunctions.cpp
Outdated
| enumDevices(gDevicePool.devices); | ||
| } catch (const sycl::exception& e) { | ||
| TORCH_WARN( | ||
| "Failed to initialize XPU devices. Did you install the driver correctly?"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message is not informative. Could you help refine the message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Do you think it is OK?
guangyey
changed the title
gujinghui
reviewed
Nov 27, 2024
| TORCH_WARN( | ||
| "Failed to initialize XPU devices. The driver may not be installed, installed incorrectly, or incompatible with the current setup. ", | ||
| "Please refer to the guideline (https://github.com/pytorch/pytorch?tab=readme-ov-file#intel-gpu-support) for proper installation and configuration."); | ||
| return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change, torch will not crash itself even without any XPU device.
Sounds good to provide a smooth warning, instead of ugly crash.
I assume we have well-defined behavior for below cases in this scenario,
- The init value of device pool is always empty
- No undefined behavior happens even if user does not check the device count.
Pls. note, initDevicePoolCallOnce is called once, that means, the warning will be raised only once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the device pool is always initialized to empty. PyTorch will raise RuntimeError in the following code if the user would like to call the other runtime API. We deliberately warn this message only once to avoid interrupting the user over time.
pytorch/c10/xpu/XPUFunctions.cpp
Lines 173 to 178 in f35bb55
| DeviceIndex device_count_ensure_non_zero() { | |
| auto count = device_count(); | |
| // Zero gpus could produce a warning in `device_count` but we fail here. | |
| TORCH_CHECK(count, "No XPU devices are available."); | |
| return count; | |
| } |
EikanWang
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
"Unrelated failure, there is an issue to track it #141705" |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…#141658) Pull Request resolved: pytorch#141658 Approved by: https://github.com/EikanWang
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
Trigger trunk jobs on your pull request
ciflow/xpu
Run XPU CI tasks
Merged
module: xpu
Intel XPU related issues
open source
release notes: xpu
release notes category
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Stack from ghstack (oldest at bottom):
cc @gujinghui @EikanWang @fengyuan14