CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 12:25:57 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=458.547254,conversation_content-fragment;desc="conversation_content fragment";dur=500.274425,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=268.021812,nginx;desc="NGINX";dur=0.608247,glb;desc="GLB";dur=95.537174
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=0yqx%2FXm8vilxEcUq52vIz7EI2ooEjbQaBPlKqmDRHC5OK%2FfR5BMvhYjDRm4aoF4xozwU8AnF3lRigKwqzsj9qXcxBGulLH5o9s2cPi4qCbhiujcZbSvm9qnBjE2iqGXnNfmMbzWGz6d7PMWdQsMewVpRNl9%2FCJSPUMYKxcIlSGZN2vsxFU1Hw0DIruIpmX2lsSSh0LtfS8ErLVzMSeUBPla5QLHTgKMyJ1llr%2BUg2%2Fu9ea%2FjrQh7wc%2F07KuM8f5wrZJ%2FyHaqVv%2F7U%2BotWP5%2Blw%3D%3D--LXlTz9FnCN4r6R19--avEUcc23z1wfjXibBWm2Mw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1483757202.1752927956; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 12:25:56 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 12:25:56 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8114:110E0E:498D00:5C5F39:687B8ED4
Avoid sending resets when it is not needed by bigmontz · Pull Request #902 · neo4j/neo4j-javascript-driver · GitHub
bigmontz
changed the title
Avoid to send reset when it is not needed
Avoid sending resets when it is not needed
Mar 16, 2022
bigmontz
force-pushed
the
5.0-minimal-resets
branch
from
March 17, 2022 17:19
bigmontz
force-pushed
the
5.0-minimal-resets
branch
2 times, most recently
from
April 12, 2022 15:45
bigmontz
force-pushed
the
5.0-minimal-resets
branch
from
April 22, 2022 12:14
bigmontz
force-pushed
the
5.0-minimal-resets
branch
from
May 5, 2022 13:05
bigmontz
force-pushed
the
5.0-minimal-resets
branch
from
May 9, 2022 13:44
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 153
Avoid sending resets when it is not needed #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d8d5f0
to
9a540a3
Compare
26529bc
to
dfd7af1
Compare
dfd7af1
to
302ff74
Compare
db7eae8
to
3fdf49f
Compare
The `RESET` should be send when a failure occurs or whenever the connection is being sent back to the pool with a pending request running, i.e. the bolt server is not in the `READY` state. These changes also affect the `verifyConnectivity` and `getServerInfo` implementation. The `RESET` message is not sent in these methods if it is a newly created connection.
a12eaeb
to
6398a1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
The
RESET
should be send when a failure occurs or whenever the connection is being sent backto the pool with a pending request running, i.e. the bolt server is not in the
READY
state.These changes also affect the
verifyConnectivity
andgetServerInfo
implementation.The
RESET
message is not sent in these methods if it is a newly created connection.