Fix `executeQuery` default return type #1055

bigmontz · 2023-01-31T10:40:50Z

The executeQuery method was returning Promise<unknown> when no transformer or typing was provided like in the example bellow:

// works
const { records } = await driver.executeQuery<EegerResult>(`query`)
// works
const { records }: EagerResult = await driver.executeQuery(`query`)
// doesn't work, but it is fixed by this change
const { records } = await driver.executeQuery(`query`)

Defining a default generic type solves the issue.

The executeQuery method was returning `Promise<unknown` when no transformer or typing was provided like in the example bellow: ``` // works const { records } = await driver.executeQuery<EegerResult>(`query`) // works const { records }: EagerResult = await driver.executeQuery(`query`) // doesn't work, but it is fixed by this change const { records } = await driver.executeQuery(`query`) ``` Defining a default generic type solves the issue.

robsdedude

well typed

fbiville

eager to see this merged 🥁

fbiville · 2023-01-31T14:18:36Z

packages/core/test/driver.test.ts

@@ -342,6 +342,32 @@ describe('Driver', () => {
        }, query, params)
      })

+      it('should be able to destruct the result in records, keys and summary', async () => {


Suggested change

it('should be able to destruct the result in records, keys and summary', async () => {

it('should be able to destructure the result in records, keys and summary', async () => {

The executeQuery method was returning `Promise<unknown` when no transformer or typing was provided like in the example bellow: ``` // works const { records } = await driver.executeQuery<EegerResult>(`query`) // works const { records }: EagerResult = await driver.executeQuery(`query`) // doesn't work, but it is fixed by this change const { records } = await driver.executeQuery(`query`) ``` Defining a default generic type solves the issue.

robsdedude approved these changes Jan 31, 2023

View reviewed changes

fbiville approved these changes Jan 31, 2023

View reviewed changes

bigmontz merged commit 15386b7 into neo4j:5.0 Jan 31, 2023

bigmontz deleted the 5.x-fix-generic-default branch January 31, 2023 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix `executeQuery` default return type #1055

Fix `executeQuery` default return type #1055

Uh oh!

bigmontz commented Jan 31, 2023

Uh oh!

robsdedude left a comment

Uh oh!

fbiville left a comment

Uh oh!

fbiville Jan 31, 2023

Uh oh!

Uh oh!

	it('should be able to destruct the result in records, keys and summary', async () => {
	it('should be able to destructure the result in records, keys and summary', async () => {

Fix executeQuery default return type #1055

Fix executeQuery default return type #1055

Uh oh!

Conversation

bigmontz commented Jan 31, 2023

Uh oh!

robsdedude left a comment

Choose a reason for hiding this comment

Uh oh!

fbiville left a comment

Choose a reason for hiding this comment

Uh oh!

fbiville Jan 31, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Fix `executeQuery` default return type #1055

Fix `executeQuery` default return type #1055