Do not inject `git::` to url when git 2.3.0 or above found #168

junegunn · 2015-02-15T04:05:24Z

This commit takes advantage of $GIT_TERMINAL_PROMPT variable added in git 2.3.0. So if the git installed on the system is 2.3.0 or above, vim-plug will not use git:: hack to prevent user prompt. However, the downside of the current implementation is that it runs git --version command on startup which should increase the startup time by a little.

junegunn · 2015-02-15T04:25:33Z

There are two alternatives that come to mind:

Defer setting up URI until it's needed. However, this requires some changes in g:plugs structure.
Remove git:: part from uri using string substitution before update/install.

junegunn · 2015-02-15T09:40:54Z

Implemented the second method. (We may need to revert the value of GIT_TERMINAL_PROMPT though.)

Related: #161, #133, #109

Do not inject `git::` to url when git 2.3.0 or above found

bruno- · 2015-02-15T20:25:56Z

Hi @junegunn,
👍
Much more elegant code than if I had submitted a pull request.
Also, I updated vim-plug locally and tested it a bit and things seem to work fine.

junegunn · 2015-02-16T00:16:09Z

@bruno- Thanks. I appreciate your feedback!

junegunn added the enhancement label Feb 15, 2015

junegunn force-pushed the git-no-prompt branch from 76d3e8d to efcfa4e Compare February 15, 2015 09:40

Remove git::@ from URI if git 2.3.0 or above is found

7fec10e

Related: #161, #133, #109

junegunn force-pushed the git-no-prompt branch from efcfa4e to 7fec10e Compare February 15, 2015 09:49

junegunn added a commit that referenced this pull request Feb 15, 2015

Merge pull request #168 from junegunn/git-no-prompt

925ec7b

Do not inject `git::` to url when git 2.3.0 or above found

junegunn merged commit 925ec7b into master Feb 15, 2015

junegunn deleted the git-no-prompt branch February 15, 2015 12:06

junegunn mentioned this pull request Feb 15, 2015

GIT_TERMINAL_PROMPT=0 git 2.3 feature #161

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Do not inject `git::` to url when git 2.3.0 or above found #168

Do not inject `git::` to url when git 2.3.0 or above found #168

Uh oh!

junegunn commented Feb 15, 2015

Uh oh!

junegunn commented Feb 15, 2015

Uh oh!

junegunn commented Feb 15, 2015

Uh oh!

bruno- commented Feb 15, 2015

Uh oh!

junegunn commented Feb 16, 2015

Uh oh!

Uh oh!

Uh oh!

Do not inject git:: to url when git 2.3.0 or above found #168

Do not inject git:: to url when git 2.3.0 or above found #168

Uh oh!

Conversation

junegunn commented Feb 15, 2015

Uh oh!

junegunn commented Feb 15, 2015

Uh oh!

junegunn commented Feb 15, 2015

Uh oh!

bruno- commented Feb 15, 2015

Uh oh!

junegunn commented Feb 16, 2015

Uh oh!

Uh oh!

Do not inject `git::` to url when git 2.3.0 or above found #168

Do not inject `git::` to url when git 2.3.0 or above found #168