fix: improve rules

antfu · antfu · commit 9ffcf2bb3286 · 2023-09-23T18:04:25.000+08:00
diff --git a/eslint.config.js b/eslint.config.js
@@ -10,7 +10,7 @@ export default antfu(
     ],
   },
   {
-    files: ['**/eslint-config/src/**/*.ts'],
+    files: ['src/**/*.ts'],
     plugins: {
       '@stylistic/migrate': stylisticMigrate,
       'sort-keys': sortKeys,
diff --git a/package.json b/package.json
@@ -35,7 +35,7 @@
     "@typescript-eslint/eslint-plugin": "^6.7.2",
     "@typescript-eslint/parser": "^6.7.2",
     "eslint-define-config": "^1.23.0",
-    "eslint-plugin-antfu": "^1.0.0-beta.5",
+    "eslint-plugin-antfu": "^1.0.0-beta.6",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-i": "^2.28.1",
     "eslint-plugin-jsdoc": "^46.8.2",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/configs/javascript.ts b/src/configs/javascript.ts
@@ -3,6 +3,7 @@ import globals from 'globals'
 import { pluginAntfu, pluginUnusedImports } from '../plugins'
 import { OFF } from '../flags'
 import type { OptionsIsInEditor } from '../types'
+import { GLOB_SRC, GLOB_SRC_EXT } from '../globs'
 
 export function javascript(options: OptionsIsInEditor = {}): FlatESLintConfigItem[] {
   return [
@@ -48,7 +49,7 @@ export function javascript(options: OptionsIsInEditor = {}): FlatESLintConfigIte
         'max-statements-per-line': ['error', { max: 1 }],
         'new-cap': ['error', { capIsNew: false, newIsCap: true, properties: true }],
         'new-parens': 'error',
-        'no-alert': 'warn',
+        'no-alert': 'error',
         'no-array-constructor': 'error',
         'no-async-promise-executor': 'error',
         'no-caller': 'error',
@@ -58,7 +59,6 @@ export function javascript(options: OptionsIsInEditor = {}): FlatESLintConfigIte
         'no-cond-assign': ['error', 'always'],
         'no-console': ['error', { allow: ['warn', 'error'] }],
         'no-const-assign': 'error',
-        'no-constant-condition': 'warn',
         'no-control-regex': 'error',
         'no-debugger': 'error',
         'no-delete-var': 'error',
@@ -213,7 +213,7 @@ export function javascript(options: OptionsIsInEditor = {}): FlatESLintConfigIte
 
         'unused-imports/no-unused-imports': options.isInEditor ? OFF : 'error',
         'unused-imports/no-unused-vars': [
-          'warn',
+          'error',
           { args: 'after-used', argsIgnorePattern: '^_', vars: 'all', varsIgnorePattern: '^_' },
         ],
 
@@ -225,7 +225,7 @@ export function javascript(options: OptionsIsInEditor = {}): FlatESLintConfigIte
       },
     },
     {
-      files: ['scripts/**/*.*', 'cli.*'],
+      files: [`scripts/${GLOB_SRC}`, `cli.${GLOB_SRC_EXT}`],
       rules: {
         'no-console': OFF,
       },
diff --git a/src/configs/stylistic.ts b/src/configs/stylistic.ts
@@ -11,8 +11,8 @@ export const javascriptStylistic: FlatESLintConfigItem[] = [
       style: pluginStylisticJs,
     },
     rules: {
-      'antfu/if-newline': 'error',
       'antfu/consistent-list-newline': 'error',
+      'antfu/if-newline': 'error',
 
       'comma-dangle': ['error', 'always-multiline'],
       'curly': ['error', 'multi-or-nest', 'consistent'],
diff --git a/src/configs/typescript.ts b/src/configs/typescript.ts
@@ -54,8 +54,6 @@ export function typescript(options?: OptionsComponentExts): FlatESLintConfigItem
         'no-redeclare': OFF,
         'no-use-before-define': OFF,
         'no-useless-constructor': OFF,
-
-        // TS
         'ts/ban-ts-comment': ['error', { 'ts-ignore': 'allow-with-description' }],
         'ts/ban-ts-ignore': OFF,
         'ts/consistent-indexed-object-style': OFF,
@@ -66,13 +64,14 @@ export function typescript(options?: OptionsComponentExts): FlatESLintConfigItem
         'ts/explicit-module-boundary-types': OFF,
         'ts/naming-convention': OFF,
         'ts/no-dupe-class-members': 'error',
+        'ts/no-dynamic-delete': OFF,
         'ts/no-empty-function': OFF,
         'ts/no-empty-interface': OFF,
         'ts/no-explicit-any': OFF,
         'ts/no-extra-parens': ['error', 'functions'],
         'ts/no-invalid-this': 'error',
-        'ts/no-loss-of-precision': 'error',
         'ts/no-invalid-void-type': OFF,
+        'ts/no-loss-of-precision': 'error',
         'ts/no-non-null-assertion': OFF,
         'ts/no-redeclare': 'error',
         'ts/no-require-imports': 'error',
diff --git a/src/configs/vue.ts b/src/configs/vue.ts
@@ -29,6 +29,8 @@ export function vue(options: OptionsHasTypeScript = {}): FlatESLintConfigItem[]
         ...pluginVue.configs['vue3-strongly-recommended'].rules as any,
         ...pluginVue.configs['vue3-recommended'].rules as any,
 
+        'node/prefer-global/process': OFF,
+
         'vue/array-bracket-spacing': ['error', 'never'],
         'vue/arrow-spacing': ['error', { after: true, before: true }],
         'vue/block-order': ['error', {
@@ -42,8 +44,8 @@ export function vue(options: OptionsHasTypeScript = {}): FlatESLintConfigItem[]
         'vue/brace-style': ['error', 'stroustrup', { allowSingleLine: true }],
         'vue/comma-dangle': ['error', 'always-multiline'],
         'vue/comma-spacing': ['error', { after: true, before: false }],
-        'vue/comma-style': ['error', 'last'],
 
+        'vue/comma-style': ['error', 'last'],
         'vue/component-name-in-template-casing': ['error', 'PascalCase'],
         'vue/component-options-name-casing': ['error', 'PascalCase'],
         'vue/custom-event-name-casing': ['error', 'camelCase'],
@@ -60,7 +62,6 @@ export function vue(options: OptionsHasTypeScript = {}): FlatESLintConfigItem[]
         'vue/keyword-spacing': ['error', { after: true, before: true }],
         'vue/max-attributes-per-line': OFF,
         'vue/multi-word-component-names': OFF,
-        'vue/no-constant-condition': 'warn',
         'vue/no-dupe-keys': OFF,
         'vue/no-empty-pattern': 'error',
         'vue/no-extra-parens': ['error', 'functions'],
@@ -73,8 +74,6 @@ export function vue(options: OptionsHasTypeScript = {}): FlatESLintConfigItem[]
           'WithStatement',
         ],
         'vue/no-restricted-v-bind': ['error', '/^v-/'],
-
-        // reactivity transform
         'vue/no-setup-props-reactivity-loss': OFF,
         'vue/no-sparse-arrays': 'error',
         'vue/no-unused-refs': 'error',

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ export default antfu(`
`10`	`10`	`],`
`11`	`11`	`},`
`12`	`12`	`{`
`13`		`- files: ['/eslint-config/src//*.ts'],`
	`13`	`+ files: ['src/*/.ts'],`
`14`	`14`	`plugins: {`
`15`	`15`	`'@stylistic/migrate': stylisticMigrate,`
`16`	`16`	`'sort-keys': sortKeys,`