| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 12:55:32 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=408.197282,conversation_content-fragment;desc="conversation_content fragment";dur=842.426924,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=225.716453,nginx;desc="NGINX";dur=0.80537,glb;desc="GLB";dur=95.878339
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=jrMQX7HC902KV88W88xCHFXe0bUkMNt9PnQG3jaZ1EcdXNJFes8TTA7ssA75uUgfPRpKWbbfiD%2Fvk0lzWFosMD%2ByObhbjzzrBWLRGLlKrQ78YIkGa0EDQNrWYRkdHA5RGHvKyErxVubeui360vHa3Ak8DW6ZN7K0fgjiHw0RG9nSO0V%2BU50rX%2FpOyVG3QaYpnhYKlDYUC0Mm5ARWR5pLrB3oMZaTXVtysoEDwh0f2FTc3easMcMuXqtIv2JrGAlEHxjy1DMhVJdNnGhWohQ1gg%3D%3D--zszqpcJMHCJn%2BYr%2F--9eV9mjit7V1abNKhJzNgtg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.325991817.1752929731; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 12:55:31 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 12:55:31 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C968:110E0E:4D5907:6117FE:687B95C3
Cleaner fix for LiveDevMultiBrowser infinite loop by peterflynn · Pull Request #10207 · adobe/brackets · GitHub
peterflynn
force-pushed
the
pflynn/fix-LiveDevMultiBrowser-loop
branch
from
December 17, 2014 19:04
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Cleaner fix for LiveDevMultiBrowser infinite loop #10207
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix-LiveDevMultiBrowser-loop * commit 'bb4f4d0fdaae509cafd467364947717f0c70cb4d': LiveDevMultiBrowser should properly search parent directories for an index.html.
…iveDevelopment.js, moving shared code to FileUtils with unit tests. Also... - fixes an unhit edge case in getParentFolder() (now getParentDirectory()) that behaves differently across platforms - removes duplicate copy of getFilenameWithoutExtension() in LiveDevelopment.js (copy in FileUtils was identical) - add/fix some unit tests for two existing FileUtils APIs
| @@ -715,14 +705,14 @@ define(function LiveDevelopment(require, exports, module) { | |||
| } | |||
|
|
|||
| var filteredFiltered = allFiles.filter(function (item) { | |||
| var parent = getParentFolder(item.fullPath); | |||
| var parent = FileUtils.getParentDirectory(item.fullPath); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think getParentDirectoryPath is cleaner to indicate it returns a string (and analogous to getDirectoryPath).
|
LGTM, just the comment on the function name and nit on the suite name. |
|
Works for me. Thanks a lot @peterflynn and @busykai. I'll close my PR. |
peterflynn
force-pushed
the
pflynn/fix-LiveDevMultiBrowser-loop
branch
from
1d7aa43 to
f044e44
Compare
|
@busykai Oops, sorry -- somehow I accidentally pushed a draft that didn't have my final changes committed. The actual changes in my real commit (should be up there now) doesn't have either of the issues you mentioned. (I used the API name |
|
@peterflynn, thanks! This looks good to me. Just some manual testing and will merge it. The tests are clean. |
|
Excellent, thanks! |
|
Merging. |
busykai
added a commit
that referenced
this pull request
Dec 17, 2014
Cleaner fix for LiveDevMultiBrowser infinite loop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This is for #10193. See discussion here for context: #10192 (comment).
Move shared code into FileUtils (with unit tests) to minimize diff in the
_getInitialDocFromCurrent()code that is duplicated between the two Live Preview impls.Also...