| CARVIEW |
Select Language
HTTP/2 302
date: Sat, 19 Jul 2025 13:37:41 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/201
server-timing: nginx;desc="NGINX";dur=1.346545,glb;desc="GLB";dur=95.67856
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=ksyUj7%2BBJYBPYs%2FIB0XB6dLuUpztP7yCesPXdN%2BMf%2FAbsReWbOlb0SfCbcnY9wePByKXNVO7%2BxZA5AheqOdE70emt8izf6kVebdX6Ko2g9i%2Fxf9BwrOrZ3ZJfKI61gVHq%2BxUNjWXvRcVivsCt36l%2FdwsKyr%2BoKitXZ6IdbGDrduaQ5EEeTVxadYaK9CzNr9qJwCHNkIaQRCpqHC1G6STyaM2cocN26eEiyQBqlHpApe%2ByvS2npDJALQyJkuk30%2FE4BMWPguHJjyWBX5OjbS%2Fxw%3D%3D--K2A72aTAl2svDrlV--uN15d6uCZSGPVgZEDF9mEQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1964391613.1752932260; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 13:37:40 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 13:37:40 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C454:0A87:5506F6:6AF45E:687B9FA4
HTTP/2 200
date: Sat, 19 Jul 2025 13:37:41 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=285.457597,conversation_content-fragment;desc="conversation_content fragment";dur=541.780478,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=224.100341,nginx;desc="NGINX";dur=1.419708,glb;desc="GLB";dur=96.60374
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: C454:0A87:550710:6AF482:687B9FA4
Fix OpenSSL cross-compaile warnings by noloader · Pull Request #201 · NLnetLabs/unbound · GitHub
noloader
changed the title
Fix OpenSSL corss-compaile warnings
Fix OpenSSL cross-compaile warnings
Mar 25, 2020
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 396
Fix OpenSSL cross-compaile warnings #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: '__ANDROID_API__' macro redefined
noloader
changed the title
gthess
reviewed
Mar 25, 2020
| @@ -65,7 +84,7 @@ case "$AOSP_CPU" in | |||
| CXXFLAGS="-march=armv7-a -mthumb -mfloat-abi=softfp -funwind-tables -fexceptions -frtti" | |||
| ;; | |||
|
|
|||
| armv8|armv8a|aarch64|arm64|arm64-v8a) | |||
| armv8*|aarch64|arm64) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it supposed to be arm64* here or the change is indeed intended?
The arm64-v8a option is not accounted for anymore but I also see that we don't use it with travis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe Android uses arm64 alone. But arm64* should be fine too. arm64* will help users who do something like ANDROID_CPU=arm64-v8a. I'd make the change if I were you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gthess, I grabbed the change for Crypto++ at Commit ccb3e869eddd. Thanks.
gthess
added a commit
that referenced
this pull request
Mar 25, 2020
- Merge PR #201 from noloader: Fix OpenSSL cross-compaile warnings.
noloader
referenced
this pull request
in weidai11/cryptopp
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR cleans up OpenSSL warnings when cross-compiling. It also uses the same
15-android.confandsetenv-android.shas Unbound.OpenSSL has a penchant for ignoring user flags. When Travis jobs were added that used
ANDROID_API=23(the minimum) it produced warnings like the following because OpenSSL stomped on Unbound's flags.The issue is cleared by removing the function
android_ndkfrom15-android.conf.A sample build with the noisy warnings is available here