You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@martinlippert I was thinking merging this for 4.29.1 as well... but this might have some risk.
Can be reproduced in a workspace with a lot of spring boot projects. Once workspace is opened, invoke content assists and cancel it over and over again. Once in 3, 5 times completion proposals would be stuck at computing.
Deadlock are:
project added (lock on projects), CU cache invalidating the project (CU cache waiting on lookup env lock) and CU cache parsing a new CU (lock on lookup env) but waiting on the CU cache (shouldn't wait on the CU cache while parsing)
project added (lock on projects), CU cache invalidating (CU cache lock, waiting on lookup env lock) CU is processed (lookup env locked), i.e. hover and project for CU or any other URL but "projects" are locked
If you have a good and reliable test scenario on your machine that keeps working with this change better than before, we can include this in 4.29.1, but beyond that, I would like to take a more careful look into the overall mechanism here. Looks quite complex to me, so looking into this again after 4.29.1 in more depth could make sense - in addition to the fix for 4.29.1.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only lock necessary pieces.