| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 15:16:35 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=352.024602,conversation_content-fragment;desc="conversation_content fragment";dur=974.117653,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=348.954929,nginx;desc="NGINX";dur=1.497931,glb;desc="GLB";dur=103.012862
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=NqKjSTgu0cJbIQA5%2B6irYaRXR%2F4Ox8tMRPZiUlOPQvUBc0nhW%2FoCg1rGtykEktY4VrGAMlYSIrfCrdcJKhXkM2HnVy1Q3sMJf4gGgazDyf3BJtNomMAdC6KhIERW5A5UJmm3atRfOzaXjPBZHzF0ZyV1pVyWvISCVUMxXQ2UM2VZgRZsTUn%2BzxTAVk7QMTdWXeufVFlW%2BxxCMU3FEdqVUVpsKy%2FXwWekfxu7Eyd6B8x5wwLYm4LocsZjnQMSxGxaAQ8aMOy1S74xEfrPGLkhYg%3D%3D--poE0pk6YdV%2BT9kjT--pVFiTOYpUVM39LUG63vZ2Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1313159096.1752938194; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 15:16:34 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 15:16:34 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8700:21B12E:5F601F:778C50:687BB6D2
sparse_broadcast_to: less memory footprint, fewer kernel launches by nikitaved · Pull Request #142364 · pytorch/pytorch · GitHub
nikitaved
added
module: sparse
Related to torch.sparse
release notes: sparse
release notes category
labels
Dec 9, 2024
nikitaved
force-pushed
the
nikitaved/coo_broadcast_less_memory
branch
3 times, most recently
from
December 9, 2024 13:32
janeyx99
added
the
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
label
Dec 9, 2024
nikitaved
force-pushed
the
nikitaved/coo_broadcast_less_memory
branch
from
December 11, 2024 11:19
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
sparse_broadcast_to: less memory footprint, fewer kernel launches #142364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142364
Note: Links to docs will display an error until the docs builds have been completed. âś… No FailuresAs of commit 1c535d6 with merge base c29b4ed ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
nikitaved
added
module: sparse
nikitaved
force-pushed
the
nikitaved/coo_broadcast_less_memory
branch
3 times, most recently
from
9db7b0a to
fae893d
Compare
janeyx99
added
the
triaged
amjames
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This looks good, minor nit in the CHECK message.
aten/src/ATen/native/TensorShape.cpp
Outdated
|
|
||
| for (int64_t i = 0; i < self.dim(); ++i) { | ||
| TORCH_CHECK(self_size[i] == 1 || self_size[i] == size[i + new_sparse_dims], | ||
| "The input's lenght ", self_size[i], " at dimension ", i, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| "The input's lenght ", self_size[i], " at dimension ", i, | |
| "The input's length ", self_size[i], " at dimension ", i, |
aten/src/ATen/native/TensorShape.cpp
Outdated
| for (int64_t i = 0; i < self.dim(); ++i) { | ||
| TORCH_CHECK(self_size[i] == 1 || self_size[i] == size[i + new_sparse_dims], | ||
| "The input's lenght ", self_size[i], " at dimension ", i, | ||
| " does not broadcast over the requested shape of lenght ", size[i + new_sparse_dims], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| " does not broadcast over the requested shape of lenght ", size[i + new_sparse_dims], | |
| " does not broadcast over the requested shape of length ", size[i + new_sparse_dims], |
cpuhrsch
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
nikitaved
force-pushed
the
nikitaved/coo_broadcast_less_memory
branch
from
fae893d to
1c535d6
Compare
|
Thank you for your reviews, guys! @pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
Trigger trunk jobs on your pull request
Merged
module: sparse
Related to torch.sparse
open source
release notes: sparse
release notes category
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
As per title.
The following implementation removes the usage of
repeat_interleave, tileandfull_coo_indicesand replaces them with broadcasting. That way we reduce memory traffic (and are likely to hit cache a lot) and the total number of launched kernels.cc @alexsamardzic @pearu @cpuhrsch @amjames @bhosmer @jcaip