CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Changed 'standard-deviation' to 'variance' in GroupNorm documentation #141982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141982
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2640aee with merge base 61dc5e9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "topic: not user facing" |
@jbschlosser @jansel @jgong5 @ezyang @c-p-i-o Please review the PR, It should solve the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also apply to the other *{Norm} ops (e.g. LayerNorm) that use the same phrasing?
@mikaylagawarecki Yes, this correction should apply to other operations if they use the same phrasing. Since the calculation is based on "variance," not "standard deviation," it's important to keep the documentation consistent. This PR solve the issue in the mentioned file. |
Would you be okay to fix the other docs as well please |
Sure, I will fix the other docs too. |
@mikaylagawarecki Fixed all docs to replace instances of 'standard-deviation' with 'variance'. Please review and merge the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
You are not authorized to force merges to this repository. Please use the regular |
@mikaylagawarecki Can you please help me with the failing tests, it is not merged due to them. |
@pytorchbot merge -r |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 3 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
@mikaylagawarecki Maybe it requires approval for the workflows or you can directly merge the PR. |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…pytorch#141982) Fixes pytorch#141315 Updated the GroupNorm documentation to replace 'standard-deviation' with 'variance' to accurately reflect the calculation method. @pytorchbot label "topic: not user facing" Pull Request resolved: pytorch#141982 Approved by: https://github.com/mikaylagawarecki
…pytorch#141982) Fixes pytorch#141315 Updated the GroupNorm documentation to replace 'standard-deviation' with 'variance' to accurately reflect the calculation method. @pytorchbot label "topic: not user facing" Pull Request resolved: pytorch#141982 Approved by: https://github.com/mikaylagawarecki
Fixes #141315
Updated the GroupNorm documentation to replace 'standard-deviation' with 'variance' to accurately reflect the calculation
method.
cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov
@pytorchbot label "topic: not user facing"