| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 15:18:54 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=291.177072,conversation_content-fragment;desc="conversation_content fragment";dur=855.152066,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=301.785606,nginx;desc="NGINX";dur=0.953719,glb;desc="GLB";dur=100.354835
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=nU7IyMlioBxXja87I7Iqy86wpAj1q9WX%2BdsFLzxY%2BUFutNENIwlW0hwciKnjKJxKcr0QDcR%2BpKhLMioKa5SPoixII9tM38SyiMlX2RpnEftAAdsARRnaz8SI9YMUlLWDpHSMMeVbnS7CsLW8F%2FeQXX9HpWKcl0N6%2BZAarUCRNfIbjsVGUL18O41t5QK%2FufbRWgmvb5qun87XnlbLXsCcFHPVpxYH%2BuNRooO2lP6tEVezvPwIjmJxKRNg2deF5WoEg7nDjJFXRxIlDnGbWezWxg%3D%3D--9bUFv3x%2FqdeoYk9%2F--roO8Qj7wQb7dSaR8IEkQPw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.836678694.1752938333; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 15:18:53 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 15:18:53 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BDF0:E3E22:8BD966:B5759D:687BB75D
[ONNX] Fix 2GB exporting crash during onnx shape type inference by titaiwangms · Pull Request #140962 · pytorch/pytorch · GitHub
titaiwangms
requested review from
shubhambhokare1,
justinchuby and
wschin
as code owners
November 18, 2024 18:06
pytorch-bot
bot
added
the
release notes: onnx
torch.onnx related changes that should show up in the release notes
label
Nov 18, 2024
titaiwangms
added
topic: bug fixes
topic category
module: regression
It used to work, and now it doesn't
module: onnx
Related to torch.onnx
labels
Nov 18, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
[ONNX] Fix 2GB exporting crash during onnx shape type inference #140962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titaiwangms
requested review from
shubhambhokare1,
justinchuby and
wschin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140962
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
✅ No FailuresAs of commit dad35d8 with merge base e429a3b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
titaiwangms
added
topic: bug fixes
justinchuby
approved these changes
Nov 18, 2024
justinchuby
reviewed
Nov 18, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Thanks for making a PR with the fix. Sorry I didn't get around to it |
|
@philass @titaiwangms |
cyyever
pushed a commit
to cyyever/pytorch
that referenced
this pull request
Nov 20, 2024
…rch#140962) Fixes pytorch#132205 Regression happened after pytorch#128675 that ONNX shape type inference error stops the exporting process during shape type inference. ONNX shape type inference during the export only does it's best to fulfill the information, and should not crash the export. Pull Request resolved: pytorch#140962 Approved by: https://github.com/justinchuby
youssef62
pushed a commit
to youssef62/pytorch
that referenced
this pull request
Nov 23, 2024
…rch#140962) Fixes pytorch#132205 Regression happened after pytorch#128675 that ONNX shape type inference error stops the exporting process during shape type inference. ONNX shape type inference during the export only does it's best to fulfill the information, and should not crash the export. Pull Request resolved: pytorch#140962 Approved by: https://github.com/justinchuby
Ryo-not-rio
pushed a commit
to Ryo-not-rio/pytorch
that referenced
this pull request
Dec 2, 2024
…rch#140962) Fixes pytorch#132205 Regression happened after pytorch#128675 that ONNX shape type inference error stops the exporting process during shape type inference. ONNX shape type inference during the export only does it's best to fulfill the information, and should not crash the export. Pull Request resolved: pytorch#140962 Approved by: https://github.com/justinchuby
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…rch#140962) Fixes pytorch#132205 Regression happened after pytorch#128675 that ONNX shape type inference error stops the exporting process during shape type inference. ONNX shape type inference during the export only does it's best to fulfill the information, and should not crash the export. Pull Request resolved: pytorch#140962 Approved by: https://github.com/justinchuby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
Trigger trunk jobs on your pull request
Merged
module: onnx
Related to torch.onnx
module: regression
It used to work, and now it doesn't
open source
release notes: onnx
torch.onnx related changes that should show up in the release notes
topic: bug fixes
topic category
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fixes #132205
Regression happened after #128675 that ONNX shape type inference error stops the exporting process during shape type inference. ONNX shape type inference during the export only does it's best to fulfill the information, and should not crash the export.