CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Updated docstrings referring to torch.expand
to point to torch.Tensor.expand
#140045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140045
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 9a30f68 with merge base eabef50 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The committers listed above are authorized under a signed CLA. |
@twaclaw you need to sign the CLA |
torch.expand_copy, | ||
r""" | ||
Performs the same operation as :func:`torch.expand`, but all output tensors | ||
Performs the same operation as :func:`torch.Tensor.expand`, but all output tensors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this? I don't see torch.expand_copy
in the generated docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this would need to be added to https://github.com/pytorch/pytorch/blob/main/docs/source/tensors.rst?plain=1#L433 to show up
That said, seems like none of the {*}_copy
functions (other than index_copy
and narrow_copy
) show up in documentation so it's probably ok not to add expand_copy
there in this PR
@svekars do you know why all these {*}_copy
variants are not in the generated docs and why they are not in the coverage skiplist?
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_1-test / test Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: linux-binary-manywheel / manywheel-py3_9-cuda12_1-test / test Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…sor.expand` (pytorch#140045) `torch.expand` was moved to `torch.Tensor.expand` but some docstrings still refer to `torch.expand` Pull Request resolved: pytorch#140045 Approved by: https://github.com/mikaylagawarecki
…sor.expand` (pytorch#140045) `torch.expand` was moved to `torch.Tensor.expand` but some docstrings still refer to `torch.expand` Pull Request resolved: pytorch#140045 Approved by: https://github.com/mikaylagawarecki
torch.expand
was moved totorch.Tensor.expand
but some docstrings still refer totorch.expand