| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 20 Jul 2025 06:35:50 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=366.718952,conversation_content-fragment;desc="conversation_content fragment";dur=948.449891,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=413.888659,nginx;desc="NGINX";dur=0.938108,glb;desc="GLB";dur=95.657188
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=aWuXv9507aDPd8r0WH7Q%2FcYyPQW8lt6v4iNhk9ok6WQyt%2FlEJhNmMg2dzZp01Mxg8dFloDPMktSPZY%2FX8WEoEIOzUYEDEn7ag%2BK9JfL4TwyFGBDtydsQXQjY2N0GcXEAYEJNkwhX4mIZsWTTO3UDfAPfFIU4axQrQtMeEk56bVzuswPySkq88B5%2Bl6ci4L2NUzwQp7H8CjACKtPyIKUHl2yIYwnimENAp0FZxvWRDQZ72dzYK44EhqAiDs9yDdBrshN9QKI8qT%2Fvgsk%2FvsEpkg%3D%3D--EuSKEgly2yF8kW1y--ZpvF5LLO2U2UP8Qjwpj5NA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.484237607.1752993349; Path=/; Domain=github.com; Expires=Mon, 20 Jul 2026 06:35:49 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 20 Jul 2026 06:35:49 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E2D0:16AA4:A62816:D711EA:687C8E45
Remove most rockset references by clee2000 · Pull Request #139922 · pytorch/pytorch · GitHub
clee2000
had a problem deploying
to
upload-stats
November 6, 2024 21:16 — with 
GitHub Actions
Failure
clee2000
had a problem deploying
to
upload-stats
November 6, 2024 22:17 — with
GitHub Actions
Failure
clee2000
force-pushed
the
csl/remove_most_rs_refs
branch
from
November 8, 2024 03:24
clee2000
force-pushed
the
csl/remove_most_rs_refs
branch
from
November 8, 2024 03:33
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Remove most rockset references #139922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Remove most rockset references #139922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139922
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 8aee590 with merge base 4715b77 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
clee2000
had a problem deploying
to
upload-stats
GitHub Actions
Failure
clee2000
had a problem deploying
to
upload-stats
GitHub Actions
Failure
clee2000
force-pushed
the
csl/remove_most_rs_refs
branch
from
228be0c to
41d1ed0
Compare
clee2000
force-pushed
the
csl/remove_most_rs_refs
branch
from
41d1ed0 to
8e450b2
Compare
huydhn
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for cleaning this up! I notice that there is one TODO that is assigned to me, but haven't had time to follow-up on it
ZainRizvi
approved these changes
Nov 12, 2024
Yes, they are all on DynamoDB now. The only one left is ao, but ao runs from torchbench https://github.com/pytorch/benchmark/blob/main/.github/workflows/torchao.yml, so it shouldn't touch any of the code path here |
|
@pytorchbot merge -f "no trunk needed" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Remove most references to rockset: * replace comments and docs with a generic "backend database" * Delete `upload_to_rockset`, so we no longer need to install the package. * Do not upload perf stats to rockset as well (we should be completely on DynamoDB now right @huydhn?) According to VSCode, it went from 41 -> 7 instances of "rockset" in the repo Pull Request resolved: pytorch#139922 Approved by: https://github.com/huydhn, https://github.com/ZainRizvi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Remove most references to rockset:
upload_to_rockset, so we no longer need to install the package.According to VSCode, it went from 41 -> 7 instances of "rockset" in the repo