| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 15:15:08 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=400.514387,conversation_content-fragment;desc="conversation_content fragment";dur=932.293831,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=343.530712,nginx;desc="NGINX";dur=1.410178,glb;desc="GLB";dur=101.171273
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=1R3Y26B%2Fy2yFLC5QR0VYAol5X%2FMOxyGtvSckvttAbFLektj3Yn0Ah%2Fg0O0LDwCFFgeP1PY0yCawFwMH1rtSq3Y%2BCg5MrAh%2FSV4s4z5RDszyxiZf7xXLObdUapXCMa3lr3Ow8TbAZBXHvgMgfSWtFXph5ZZUsLYTaisdA4zlqmRlZWgJozn93MkO5RSuJKg9oWbMBi%2FrQmWQXOLovevLxWppmMaUTiJ1lhM5nXnvEsagf75TnSsZEZ5BQCBXJWTq6GvDK82HzWB%2F%2BdoWBp7s1xA%3D%3D--%2BtIXrk57fb%2FOED3s--x18ZxchNLlZiGf2CIXVgFQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.838036876.1752938107; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 15:15:07 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 15:15:07 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A916:305A02:1C7CC7:237860:687BB67B
[aot_compile] propagate ShapeEnv during lowering by pianpwk · Pull Request #138362 · pytorch/pytorch · GitHub
pytorch-bot
bot
added
ciflow/inductor
module: inductor
release notes: AO frontend
labels
Oct 18, 2024
facebook-github-bot
force-pushed
the
export-D64613290
branch
from
October 18, 2024 20:41
facebook-github-bot
force-pushed
the
export-D64613290
branch
from
October 18, 2024 22:51
facebook-github-bot
force-pushed
the
export-D64613290
branch
from
October 23, 2024 17:46
facebook-github-bot
force-pushed
the
export-D64613290
branch
from
October 24, 2024 04:59
facebook-github-bot
force-pushed
the
export-D64613290
branch
from
October 24, 2024 06:11
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
[aot_compile] propagate ShapeEnv during lowering #138362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138362
Note: Links to docs will display an error until the docs builds have been completed. âś… You can merge normally! (1 Unrelated Failure)As of commit a808449 with merge base 96b30dc ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: inductor
release notes: AO frontend
labels
|
This pull request was exported from Phabricator. Differential Revision: D64613290 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
Summary: Pull Request resolved: #138362 Differential Revision: D64613290
facebook-github-bot
force-pushed
the
export-D64613290
branch
from
393a2f4 to
3411fa6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64613290 |
angelayi
approved these changes
Oct 18, 2024
pianpwk
commented
Oct 18, 2024
| @@ -3609,6 +3611,24 @@ def forward(self, x): | |||
| self.check_model(Model(), example_inputs) | |||
|
|
|||
|
|
|||
| class AOTInductorLoggingTest(LoggingTestCase): | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really sure where to put this
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
Summary: Pull Request resolved: #138362 Differential Revision: D64613290
facebook-github-bot
force-pushed
the
export-D64613290
branch
from
3411fa6 to
8138621
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64613290 |
|
@pianpwk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@pianpwk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
Summary: We found that `export() -> _inductor.aot_compile()` lowering, 3 different ShapeEnvs get created, leading to errors when one ShapeEnv processes expressions created by another ShapeEnv. This plumbs the 2 places where ShapeEnv creation happens, detecting the original ShapeEnv from the GraphModule example values, so the original ShapeEnv is just reused. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov rec Reviewed By: ColinPeppler Differential Revision: D64613290 Pulled By: pianpwk
facebook-github-bot
force-pushed
the
export-D64613290
branch
from
531c192 to
c704e5a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64613290 |
|
@pianpwk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@pianpwk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
Summary: We found that `export() -> _inductor.aot_compile()` lowering, 3 different ShapeEnvs get created, leading to errors when one ShapeEnv processes expressions created by another ShapeEnv. This plumbs the 2 places where ShapeEnv creation happens, detecting the original ShapeEnv from the GraphModule example values, so the original ShapeEnv is just reused. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov rec Reviewed By: ColinPeppler Differential Revision: D64613290 Pulled By: pianpwk
facebook-github-bot
force-pushed
the
export-D64613290
branch
from
76c7bda to
262f24f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64613290 |
Summary: We found that `export() -> _inductor.aot_compile()` lowering, 3 different ShapeEnvs get created, leading to errors when one ShapeEnv processes expressions created by another ShapeEnv. This plumbs the 2 places where ShapeEnv creation happens, detecting the original ShapeEnv from the GraphModule example values, so the original ShapeEnv is just reused. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov rec Reviewed By: ColinPeppler Differential Revision: D64613290 Pulled By: pianpwk
facebook-github-bot
force-pushed
the
export-D64613290
branch
from
262f24f to
a808449
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64613290 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchmergebot merge -f "skipping pending macos job" |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/inductor
ciflow/trunk
Trigger trunk jobs on your pull request
fb-exported
Merged
module: dynamo
module: inductor
release notes: AO frontend
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
We found that
export() -> _inductor.aot_compile()lowering, 3 different ShapeEnvs get created, leading to errors when one ShapeEnv processes expressions created by another ShapeEnv. This plumbs the 2 places where ShapeEnv creation happens, detecting the original ShapeEnv from the GraphModule example values, so the original ShapeEnv is just reused.Differential Revision: D64613290
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov @rec